Skip to content

chore: Karma+Jasmine から vitest+jsdom へ移行 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdlabo merged 2 commits into from
Jun 18, 2026
Merged

chore: Karma+Jasmine から vitest+jsdom へ移行 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d201ca7
chore: Karma+Jasmine から vitest+jsdom へ移行
rdlabo Jun 18, 2026
03e060e
ci: テスト実行を vitest 構成に合わせる（ChromeHeadless 廃止）
rdlabo Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ jobs:
${{ runner.os }}-node-
- run: npm install
- run: npm run build
- run: npm run test -- ${{ matrix.project }} --no-watch --no-progress --browsers=ChromeHeadlessCI
- run: npm run test -- ${{ matrix.project }} --watch=false
58 changes: 33 additions & 25 deletions angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,17 @@
}
},
"test": {
"builder": "@angular/build:karma",
"builder": "@angular/build:unit-test",
"options": {
"polyfills": [],
"tsConfig": "projects/demo/tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"browsers": "ChromeHeadlessNoSandbox",
"inlineStyleLanguage": "scss",
"assets": [
"projects/demo/src/favicon.ico",
"projects/demo/src/assets"
],
"styles": [
"projects/demo/src/styles.scss"
],
"scripts": []
"buildTarget": "demo:build",
"runner": "vitest",
"runnerConfig": "vitest.config.ts"
},
"configurations": {
"ci": {
"watch": false
}
}
},
"lint": {
Expand Down Expand Up @@ -114,12 +110,16 @@
"defaultConfiguration": "production"
},
"test": {
"builder": "@angular/build:karma",
"builder": "@angular/build:unit-test",
"options": {
"tsConfig": "projects/photo-editor/tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"browsers": "ChromeHeadlessNoSandbox",
"polyfills": []
"runner": "vitest",
"runnerConfig": "vitest.config.ts"
},
"configurations": {
"ci": {
"watch": false
}
Comment on lines +113 to +122

@devin-ai-integration devin-ai-integration Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Library projects missing buildTarget option unlike the demo project

In angular.json, the demo project's test configuration includes "buildTarget": "demo:build" (line 69), but the library projects (photo-editor, scroll-header, scroll-strategies) do not include a buildTarget option. The @angular/build:unit-test schema shows buildTarget as an optional property (pattern-validated string). Libraries may not need it since they use ng-packagr rather than the application builder, but this inconsistency is worth noting — if the builder requires a build target for proper compilation, library tests could fail.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

}
},
"lint": {
Expand Down Expand Up @@ -156,12 +156,16 @@
"defaultConfiguration": "production"
},
"test": {
"builder": "@angular/build:karma",
"builder": "@angular/build:unit-test",
"options": {
"tsConfig": "projects/scroll-header/tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"browsers": "ChromeHeadlessNoSandbox",
"polyfills": []
"runner": "vitest",
"runnerConfig": "vitest.config.ts"
},
"configurations": {
"ci": {
"watch": false
}
}
},
"lint": {
Expand Down Expand Up @@ -198,12 +202,16 @@
"defaultConfiguration": "production"
},
"test": {
"builder": "@angular/build:karma",
"builder": "@angular/build:unit-test",
"options": {
"tsConfig": "projects/scroll-strategies/tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"browsers": "ChromeHeadlessNoSandbox",
"polyfills": []
"runner": "vitest",
"runnerConfig": "vitest.config.ts"
},
"configurations": {
"ci": {
"watch": false
}
}
},
"lint": {
Expand Down
66 changes: 0 additions & 66 deletions karma.conf.js
View file
Open in desktop

This file was deleted.

Loading