Skip to content

fix(kit): preserve offline API reachability - #36

Merged
rdlabo merged 1 commit into
mainfrom
fix/offline-fallback-transport
Jul 25, 2026
Merged

fix(kit): preserve offline API reachability#36
rdlabo merged 1 commit into
mainfrom
fix/offline-fallback-transport

Conversation

@rdlabo

@rdlabo rdlabo commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep API reachability offline when an inner interceptor returns a local replica response
  • avoid treating X-Offline-Response: local as a successful remote transport
  • add a regression test covering the nested-interceptor fallback path

Verification

  • npx ng test kit --watch=false (35 files / 484 tests)
  • npm run lint
  • npm run prebuild:kit
  • git diff --check

Follow-up required by winecode PR #401 acceptance review.

@netlify

netlify Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploy Preview for rdlabo-ionic-angular-library ready!

Name Link
🔨 Latest commit 383a779
🔍 Latest deploy log https://app.netlify.com/projects/rdlabo-ionic-angular-library/deploys/6a6445e15948a8000876fc50
😎 Deploy Preview https://deploy-preview-36--rdlabo-ionic-angular-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdlabo
rdlabo marked this pull request as ready for review July 25, 2026 05:15
@rdlabo
rdlabo merged commit 993445f into main Jul 25, 2026
12 checks passed

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant