Skip to content

fix: support offline replica DSL without strictNullChecks - #32

Merged
rdlabo merged 2 commits into
mainfrom
fix/offline-dsl-nonstrict-null
Jul 24, 2026
Merged

fix: support offline replica DSL without strictNullChecks#32
rdlabo merged 2 commits into
mainfrom
fix/offline-dsl-nonstrict-null

Conversation

@rdlabo

@rdlabo rdlabo commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve exact-key and primitive-affinity checks when a consumer has strictNullChecks disabled
  • degrade only compile-time nullability matching, because TypeScript erases nullability in that mode
  • add a non-strict consumer type compilation regression test

Context

Tipsys PR #223 uses the offline replica DSL from 21.4.3 while its existing app tsconfig has strictNullChecks=false. The current conditional therefore classifies every property as nullable and rejects valid required column builders.

Verification

  • npm run prebuild:kit
  • npx tsc -p projects/kit/offline/tsconfig.nonstrict-null.json

Open in Devin Review

@netlify

netlify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy Preview for rdlabo-ionic-angular-library ready!

Name Link
🔨 Latest commit e530462
🔍 Latest deploy log https://app.netlify.com/projects/rdlabo-ionic-angular-library/deploys/6a63dea5ed558a00087edeb4
😎 Deploy Preview https://deploy-preview-32--rdlabo-ionic-angular-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@rdlabo
rdlabo force-pushed the fix/offline-dsl-nonstrict-null branch from 01b84a3 to 62c7c91 Compare July 24, 2026 15:30
@rdlabo

rdlabo commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

レビューサイクル完了

  • 上長レビュー: APPROVED
  • 第三者受入レビュー: APPROVED
  • 後方互換: runtime descriptor / DDL / public API は不変。strict consumer の nullability lock を維持
  • non-strict consumer: required/nullable builders、exact keys、primitive affinity の型回帰テストを追加
  • CI: lint、kit含むtest matrix、e2e、test-actions、専用 non-strict type compile が全て成功

blocking はありません。Readyです。

@rdlabo
rdlabo merged commit 65021f8 into main Jul 24, 2026
12 checks passed
@rdlabo
rdlabo deleted the fix/offline-dsl-nonstrict-null branch July 24, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant