Skip to content

fix(kit): disable Ionic form submitters - #22

Merged
rdlabo merged 1 commit into
mainfrom
fix/submit-disable-handler
Jul 16, 2026
Merged

fix(kit): disable Ionic form submitters#22
rdlabo merged 1 commit into
mainfrom
fix/submit-disable-handler

Conversation

@rdlabo

@rdlabo rdlabo commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • extend disableHandler to handle native submit events
  • resolve Ionic's hidden submit proxy back to associated ion-button[form] hosts
  • preserve each submitter's original disabled state and prevent default form navigation

Verification

  • npm test (all projects, 248 tests)
  • npm run lint
  • npm run prebuild
  • focused dom.spec.ts (5 tests, including external ion-button[form])

Open in Devin Review

@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for rdlabo-ionic-angular-library ready!

Name Link
🔨 Latest commit b7edf0e
🔍 Latest deploy log https://app.netlify.com/projects/rdlabo-ionic-angular-library/deploys/6a58e61969acd40008ec5a0e
😎 Deploy Preview https://deploy-preview-22--rdlabo-ionic-angular-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@rdlabo
rdlabo merged commit ed4fcd1 into main Jul 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant