Fix dynamic virtual scroll geometry - #21
Merged
Merged
Conversation
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rdlabo
marked this pull request as ready for review
July 16, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
column-reverselayoutcalcIndexbehavior and exposecalculateItemCountForPixelDistancefor mathematically continuous resultsRoot cause
The strategy converted pixel distances into fractional item counts and then combined
floor,ceil, and extra-item corrections. Those calculations used inconsistent coordinate origins for forward, backward, and reverse ranges, so the rendered range could only be tuned empirically.Impact
Rendered ranges, content offsets, total content size, and scrolled indexes now derive from the same prefix-sum geometry. Normal scroll events use cached prefix sums and binary search. Reverse
scrollToIndex()now converts logical positive offsets to the negative nativescrollTopused by the demo's doublecolumn-reverselayout.Validation
npx ng test scroll-strategies --watch=false— 14 tests passednpm run lint— all projects passednpm run prebuild:scroll-strategies— production package build passedscrollTop = -886and logicalscrollOffset = 886git diff --check