fix(actions): pass bundlePath to Capawesome live update bundle - #12
Merged
Conversation
main() called bundleArgs(options) with bundlePath, but bundleArgs only read outputPath, so --output-path was undefined and upload could not find bundle.zip. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for rdlabo-ionic-angular-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-live-updatecomposite action で、bundle.zipが生成されず upload が落ちる不具合を修正main()がbundleArgs(options)に渡すオプションはbundlePathだが、bundleArgsはoutputPathだけ見て--output-pathにundefinedを渡していたbundleArgsがoutputPath ?? bundlePathを使うようにし、main フローのテストで--output-path/ upload--pathがbundle.zipであることを検証Impact
publish-live-update）のみ。npm 公開 kit 本体の API / ランタイムには影響なしv6.1.0-2で本番 OTA publish がこの不具合で失敗しているため、main マージ後すぐ利用想定（各 app は暫定で@mainpin）Test plan
npm run test:actions（31 passed、bundle output パスの回帰テスト追加含む）-Nタグ再切り → Capawesome upload 成功を確認Review notes
@mainへ寄せる app 側 PR は別（本 PR マージが前提）