Skip to content

Include Sid field for findings#10

Open
agentreno wants to merge 1 commit into
rdkls:masterfrom
agentreno:master
Open

Include Sid field for findings#10
agentreno wants to merge 1 commit into
rdkls:masterfrom
agentreno:master

Conversation

@agentreno
Copy link
Copy Markdown

This field can also fail late (at terraform apply time) if it's not formatted correctly and Parliament can warn about this - it just needs including in your field mappings.

Tested manually on:

data "aws_iam_policy_document" "example" {
    statement {
        sid = "foo bar"
        actions = [
            "s3:GetObject",
        ]
        resources = [
            "arn:aws:s3:::mybucket/*",
        ]
    }
}
test.tf
INVALID_SID
Details:
  {'Effect': 'Allow', 'Sid': 'foo bar', 'Action': ['s3:GetObject'], 'Resource': ['arn:aws:s3:::mybucket/*']}
Location:
  {'filepath': None}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant