Develop#126
Open
RahulRengeshOfficial wants to merge 330 commits into
Open
Conversation
- Increase coverage for estb_firmware_handler.go functions - GetCheckMinFirmwareHandler: 71.9% → 100% (+28.1%) - GetEstbFirmwareVersionInfoPath: 69.7% → 100% (+30.3%) - Added comprehensive edge case tests for: * IP parsing paths (query param vs body) * Query parameter filtering (clientProtocol, cert expiry) * Body parameter parsing * Security token manager code path * Cert expiry handling * Multi-value query parameters * Application type extraction * MAC normalization Impact: - Main dataapi package: 51.1% → 52.2% (+1.1%) - Overall coverage: 38.2% → 38.9% (+0.7%) - 20 new test functions, all passing - Proper mocking to avoid DB/service dependencies Files: - dataapi/estb_firmware_handler_test.go: +20 tests - PROGRESS_SUMMARY_ESTB_FIRMWARE_HANDLER.md: detailed analysis
new flag to determine whether to add security token if no new fw offered
Removed added debug logs
Current behavior is consistent with existing logic where unknown-account detection uses the same utility check.. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ance error handling for partner route requests
Add condition enable_fw_penetration_metrics flag
…into feature/foxtelMigration
…sage of ContextMap
Feature/foxtel migration
…eature/foxtelMigration
Feature/foxtel migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.