Skip to content

Develop#126

Open
RahulRengeshOfficial wants to merge 330 commits into
mainfrom
develop
Open

Develop#126
RahulRengeshOfficial wants to merge 330 commits into
mainfrom
develop

Conversation

@RahulRengeshOfficial

Copy link
Copy Markdown
Contributor

No description provided.

RahulRengeshOfficial and others added 30 commits October 28, 2025 19:10
- Increase coverage for estb_firmware_handler.go functions
- GetCheckMinFirmwareHandler: 71.9% → 100% (+28.1%)
- GetEstbFirmwareVersionInfoPath: 69.7% → 100% (+30.3%)
- Added comprehensive edge case tests for:
  * IP parsing paths (query param vs body)
  * Query parameter filtering (clientProtocol, cert expiry)
  * Body parameter parsing
  * Security token manager code path
  * Cert expiry handling
  * Multi-value query parameters
  * Application type extraction
  * MAC normalization

Impact:
- Main dataapi package: 51.1% → 52.2% (+1.1%)
- Overall coverage: 38.2% → 38.9% (+0.7%)
- 20 new test functions, all passing
- Proper mocking to avoid DB/service dependencies

Files:
- dataapi/estb_firmware_handler_test.go: +20 tests
- PROGRESS_SUMMARY_ESTB_FIRMWARE_HANDLER.md: detailed analysis
new flag to determine whether to add security token if no new fw offered
Copilot AI review requested due to automatic review settings July 9, 2026 13:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

gravi21 and others added 8 commits July 10, 2026 19:04
Current behavior is consistent with existing logic where unknown-account detection uses the same utility check..

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ance error handling for partner route requests
Add condition enable_fw_penetration_metrics flag
Copilot AI review requested due to automatic review settings July 10, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 13, 2026 15:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 14, 2026 15:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.