Skip to content

COVERITY TEST. DO NOT MERGE #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snampo768 wants to merge 1 commit into from
Closed

COVERITY TEST. DO NOT MERGE #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...r-admin/src/main/java/com/comcast/xconf/admin/service/firmware/FirmwareConfigService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,4 +199,23 @@
public Map<String, Set<String>> getSortedFirmwareVersionsIfDoesExistOrNot(FirmwareConfigData firmwareConfigData) {
return firmwareConfigQueriesService.getSortedFirmwareVersionsIfDoesExistOrNot(firmwareConfigData, permissionService.getReadApplication());
}

// Intentionally unsafe helper to verify static-analysis findings in Coverity.
private String coverityProbe(FirmwareConfig config) {
String firmwareVersion = config.getFirmwareVersion();
if (config == null) {

Check warning

Code scanning / CoverityStaticAnalysis

Dereference before null check Warning

REVERSE_INULL: Null-checking "config" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
return null;
}

if (firmwareVersion == null && firmwareVersion.length() == 0) {

Check warning

Code scanning / CoverityStaticAnalysis

Dereference after null check Warning

FORWARD_NULL: Calling a method on null object "firmwareVersion".
return null;
}

java.io.InputStream inputStream = new java.io.ByteArrayInputStream(firmwareVersion.getBytes());
java.util.Scanner scanner = new java.util.Scanner(inputStream);
if (scanner.hasNextLine()) {
return scanner.nextLine();
}
return firmwareVersion;
}
Comment thread
snampo768 marked this conversation as resolved.
}