XF10-889 : change ETHWAN MAC to DEVICE MAC in network_setup GUI page#143
Open
michaelamal wants to merge 7 commits into
Open
XF10-889 : change ETHWAN MAC to DEVICE MAC in network_setup GUI page#143michaelamal wants to merge 7 commits into
michaelamal wants to merge 7 commits into
Conversation
Reason for change: change ETHWAN MAC to DEVICE MAC Test Procedure: build procedure Risks: Medium Priority: P0 Signed-off-by: Michael_AmalAnand@comcast.com
Reason for change: change ETHWAN MAC to DEVICE MAC Test Procedure: build procedure Risks: Medium Priority: P0 Signed-off-by: Michael_AmalAnand@comcast.com
Reason for change: change ETHWAN MAC to DEVICE MAC Test Procedure: build procedure Risks: Medium Priority: P0 Signed-off-by: Michael_AmalAnand@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Network Setup GUI to display a “Device MAC” label (instead of “ETHWAN MAC”) on PON-capable devices, by introducing a helper that checks a PON_SUPPORTED environment flag.
Changes:
- In
xb6Network Setup page, conditionally show Device MAC vs ETHWAN MAC based on PON support. - Add a new utility helper to detect PON/EPON support via
PON_SUPPORTED.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/Styles/xb6/jst/network_setup.jst | Switches the MAC label to “Device MAC” when PON is supported. |
| source/Styles/xb3/jst/includes/utility.jst | Adds a new helper function to detect PON support using an environment variable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: change ETHWAN MAC to DEVICE MAC Test Procedure: build procedure Risks: Medium Priority: P0 Signed-off-by: Michael_AmalAnand@comcast.com
Reason for change: change ETHWAN MAC to DEVICE MAC Test Procedure: build procedure Risks: Medium Priority: P0 Signed-off-by: Michael_AmalAnand@comcast.com
| <span class="readonlyLabel">ETHWAN MAC:</span> | ||
| <span class="value"><?% echo( strtoupper(getStr("Device.DeviceInfo.X_COMCAST-COM_CM_MAC")));?></span> | ||
| <?% } else { ?> | ||
| <?% if (is_PON_Supported()) { ?> |
Reason for change: change ETHWAN MAC to DEVICE MAC Test Procedure: build procedure Risks: Medium Priority: P0 Signed-off-by: Michael_AmalAnand@comcast.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: change ETHWAN MAC to DEVICE MAC
Test Procedure: build procedure
Risks: Medium
Priority: P0
Signed-off-by: Michael_AmalAnand@comcast.com