CBR2-2336 Gate 2.4GHz ax mode options by Device.WiFi.2G80211axEnable#73
Open
pavankumar464 wants to merge 1 commit into
Open
CBR2-2336 Gate 2.4GHz ax mode options by Device.WiFi.2G80211axEnable#73pavankumar464 wants to merge 1 commit into
pavankumar464 wants to merge 1 commit into
Conversation
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the 2.4GHz “Mode” UI so that 802.11ax options are shown only when Device.WiFi.2G80211axEnable indicates ax is enabled, aligning the UI with device capability/feature gating.
Changes:
- Reads
Device.WiFi.2G80211axEnablein the 2.4GHz wireless configuration page. - Gates the 2.4GHz mode dropdown to hide the
g,n,axoption when ax is disabled. - Applies the same gating logic in the wireless configuration edit page.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/Styles/xb3/jst/wireless_network_configuration.jst | Gates 2.4GHz mode options based on 2G80211axEnable. |
| source/Styles/xb3/jst/wireless_network_configuration_edit.jst | Applies the same 2.4GHz ax gating in the edit flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1430
to
1435
| <?% if ((strstr($support_mode, "ax")) && ($axEnable == "true")){ ?> | ||
| <option value="g,n" <?% if ("g,n" == $wireless_mode) echo( 'selected="selected"');?> >802.11 g/n</option> | ||
| <option value="g,n,ax" <?% if ("g,n,ax" == $wireless_mode) echo( 'selected="selected"');?> >802.11 g/n/ax</option> | ||
| <?% } else if ((strstr($support_mode, "ax")) && ($axEnable == "false")){ ?> | ||
| <option value="g,n" <?% if ("g,n" == $wireless_mode) echo( 'selected="selected"');?> >802.11 g/n</option> | ||
| <?% } |
Comment on lines
+931
to
+938
| if ((strstr($support_mode_2g, "ax")) && ($axEnable == "true")){ | ||
| echo( '<option value="g,n" '); echo( ( "g,n"==$wireless_mode)? 'selected':''); echo('>802.11 g/n</option>'); | ||
| echo( '<option value="g,n,ax" '); echo( ("g,n,ax"==$wireless_mode)? 'selected':''); echo('>802.11 g/n/ax</option>'); | ||
| } | ||
| else if ((strstr($support_mode_2g, "ax")) && ($axEnable == "false")) | ||
| { | ||
| echo( '<option value="g,n" '); echo( ( "g,n"==$wireless_mode)? 'selected':''); echo('>802.11 g/n</option>'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.