RDK-61615: Remove Sensitive StringFrom Open Source#65
Open
aruna007 wants to merge 1 commit into
Open
Conversation
Reason for change: Remove Sensitive String (pattern180) From Open Source Test Procedure: Tested the tasks locally Risks: Low Signed-off-by: Aruna_Appikatla@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a sensitive hardcoded string from the XB3 web UI startup script by replacing the temporary file identifier used to build the lighttpd key+cert bundle.
Changes:
- Replaced the hardcoded temporary ID path used for
GetConfigFileoutput from/tmp/trpfizyanrlnto/tmp/myrouter-webui.
Comments suppressed due to low confidence (1)
source/Styles/xb3/config/webgui.sh:61
- Using a fixed, predictable path in /tmp for the key+cert bundle increases the risk of collisions (concurrent runs) and makes the file easier to pre-create/target (e.g., symlink/clobber) while it contains sensitive material. Also, $ID should be quoted and the existence check should match the invoked path.
ID="/tmp/myrouter-webui"
GetConfigFile $ID
cp /nvram/certs/myrouter.io.cert.pem /tmp/.webui/
#lighttpd expects file with key and pem
cat /tmp/.webui/myrouter.io.cert.pem >> $ID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove Sensitive String (pattern180) From Open Source
Test Procedure: Tested the tasks locally
Risks: Low
Signed-off-by: Aruna_Appikatla@comcast.com