Skip to content

feat: add service.version to OTel resource attributes #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lstruman merged 1 commit into from
Jun 22, 2026
Merged

feat: add service.version to OTel resource attributes #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions tracing/otel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,15 @@ func otelNoopTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, erro
return noop.NewTracerProvider(), nil
}

func otelResource(xpcTracer *XpcTracer) *resource.Resource {
return resource.NewWithAttributes(
semconv.SchemaURL,
semconv.ServiceNameKey.String(xpcTracer.appName),
semconv.ServiceNamespaceKey.String(xpcTracer.appEnv),
semconv.ServiceVersionKey.String(xpcTracer.appVersion),
)
}

func otelStdoutTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, error) {
option := stdouttrace.WithPrettyPrint()
exporter, err := stdouttrace.New(option)
Expand All @@ -113,13 +122,7 @@ func otelStdoutTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, er
sdktrace.WithBatcher(exporter,
// Default is 5s. Set to 1s for demonstrative purposes.
sdktrace.WithBatchTimeout(time.Second)),
sdktrace.WithResource(
resource.NewWithAttributes(
semconv.SchemaURL,
semconv.ServiceNameKey.String(xpcTracer.appName),
semconv.ServiceNamespaceKey.String(xpcTracer.appEnv),
),
),
sdktrace.WithResource(otelResource(xpcTracer)),
)
return tp, nil
}
Expand All @@ -139,13 +142,7 @@ func otelHttpTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, erro

return sdktrace.NewTracerProvider(
sdktrace.WithBatcher(exporter),
sdktrace.WithResource(
resource.NewWithAttributes(
semconv.SchemaURL,
semconv.ServiceNameKey.String(xpcTracer.appName),
semconv.ServiceNamespaceKey.String(xpcTracer.appEnv),
),
),
sdktrace.WithResource(otelResource(xpcTracer)),
), nil
}

Expand Down