RDKB-65187 - WAN Manager - Telemetry for Ignite. by LakshminarayananShenbagaraj · Pull Request #213 · rdkcentral/wan-manager

LakshminarayananShenbagaraj · 2026-05-26T09:53:25Z

Reason for change:
Wan Manager MUST send WAN_DOWN_DURATION event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_DOWN_DURATION
Emitted as:t2_event_s("WAN_DOWN_DURATION", "||")

Test Procedure:

WANManager should run without any issue

Risks: Medium

Reason for change: Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_FAILURE_TIME Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs") Test Procedure: 1. WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

This PR adds WAN outage duration telemetry (“WAN_FAILURE_TIME_split”) intended to measure customer no-internet time using a monotonic clock, and includes several related IPv6/MAP-T and connectivity-check adjustments in the WAN interface state machine.

Changes:

Add monotonic WAN failure timer tracking and emit telemetry when WAN service transitions back to “started”.
Refactor IPv6 DAD/default-route readiness check to support LAN-bridge vs WAN-interface behavior (bridge-mode handling).
Adjust IPv6 teardown / MAP-T paths, including removing some IPv6 cleanup and adding additional logging and LAN sync hooks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Reason for change: Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_FAILURE_TIME Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs") Test Procedure: 1. WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

github-advanced-security · 2026-06-01T12:08:59Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.

Reason for change: Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_FAILURE_TIME Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "secs") Test Procedure: WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 10 comments.

Reason for change: Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_FAILURE_TIME Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs") Test Procedure: 1. WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Reason for change: Wan Manager MUST send WAN_FAILURE_TIME event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_FAILURE_TIME Emitted as:t2_event_s("WAN_FAILURE_TIME_split", "<N>secs") Test Procedure: 1. WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Reason for change: Wan Manager MUST send WAN_DOWN_DURATION event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_DOWN_DURATION Emitted as:t2_event_s("WAN_DOWN_DURATION", "<Previously Activated Interface>|<Current Active Interface>|<Nseconds>") Test Procedure: WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Reason for change: Wan Manager MUST send WAN_DOWN_DURATION event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_DOWN_DURATION Emitted as:t2_event_s("WAN_DOWN_DURATION", "||") Test Procedure: WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Reason for change: Wan Manager MUST send WAN_DOWN_DURATION event with total time the customer has no internet service, from the moment WAN outage is detected to when internet service resumes via any available interface (HOTSPOT failover). The measured time MUST be reported as a positive integer in seconds and not be affected by NTP adjustments or system clock changes during the measurement window. Marker name:WAN_DOWN_DURATION Emitted as:t2_event_s("WAN_DOWN_DURATION", "||") Test Procedure: WANManager should run without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

LakshminarayananShenbagaraj self-assigned this May 26, 2026

LakshminarayananShenbagaraj requested a review from a team as a code owner May 26, 2026 09:53

Copilot AI review requested due to automatic review settings May 26, 2026 09:53

LakshminarayananShenbagaraj added the enhancement New feature or request label May 26, 2026

LakshminarayananShenbagaraj marked this pull request as draft May 26, 2026 09:53

Copilot started reviewing on behalf of LakshminarayananShenbagaraj May 26, 2026 09:53 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

LakshminarayananShenbagaraj added 4 commits May 26, 2026 16:03

LakshminarayananShenbagaraj marked this pull request as ready for review June 1, 2026 12:05

Copilot AI review requested due to automatic review settings June 1, 2026 12:05

Copilot started reviewing on behalf of LakshminarayananShenbagaraj June 1, 2026 12:06 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 1, 2026 15:04

Copilot started reviewing on behalf of LakshminarayananShenbagaraj June 1, 2026 15:05 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

LakshminarayananShenbagaraj added 2 commits June 3, 2026 11:59

Copilot AI review requested due to automatic review settings June 3, 2026 11:05

Copilot started reviewing on behalf of LakshminarayananShenbagaraj June 3, 2026 11:05 View session

LakshminarayananShenbagaraj and others added 2 commits June 3, 2026 12:06

Update wanmgr_interface_sm.c

0038b91

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 3, 2026 11:11

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Potential fix for pull request finding

edf7939

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 9, 2026 13:33

Copilot started reviewing on behalf of LakshminarayananShenbagaraj July 9, 2026 13:33 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Outdated

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Copilot AI review requested due to automatic review settings July 9, 2026 15:18

Copilot started reviewing on behalf of LakshminarayananShenbagaraj July 9, 2026 15:19 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Outdated

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Outdated

S-Parthiban-Selvaraj requested changes Jul 9, 2026

View reviewed changes

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Outdated

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Outdated

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Outdated

Copilot AI review requested due to automatic review settings July 10, 2026 10:26

Copilot started reviewing on behalf of LakshminarayananShenbagaraj July 10, 2026 10:26 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/WanManager/wanmgr_main.c

Copilot AI review requested due to automatic review settings July 10, 2026 14:29

Copilot started reviewing on behalf of LakshminarayananShenbagaraj July 10, 2026 14:30 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Updated code comments.

d34fc11

Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>

Copilot AI review requested due to automatic review settings July 13, 2026 10:27

Copilot started reviewing on behalf of LakshminarayananShenbagaraj July 13, 2026 10:28 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/WanManager/wanmgr_main.c

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

S-Parthiban-Selvaraj approved these changes Jul 14, 2026

View reviewed changes

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c Outdated

Merge branch 'main' into RDKB-65029-Test

eaf996f

Copilot AI review requested due to automatic review settings July 14, 2026 16:52

Copilot started reviewing on behalf of LakshminarayananShenbagaraj July 14, 2026 16:52 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

Comment thread source/WanManager/wanmgr_main.c

Comment thread source/TR-181/middle_layer_src/wanmgr_rdkbus_apis.c

guto86 approved these changes Jul 15, 2026

View reviewed changes

guto86 merged commit 6751e16 into main Jul 15, 2026
8 checks passed

github-actions Bot locked and limited conversation to collaborators Jul 15, 2026

Uh oh!

Conversation

LakshminarayananShenbagaraj commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security AI commented Jun 1, 2026

What Enabling Code Scanning Means:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LakshminarayananShenbagaraj commented May 26, 2026 •

edited

Loading