Skip to content

RDKBACCL-1887: Port sysint scripts for ARM system ready#353

Open
mahanteshchitt wants to merge 2 commits into
rdkcentral:developfrom
mahanteshchitt:migrate-to-ARM
Open

RDKBACCL-1887: Port sysint scripts for ARM system ready#353
mahanteshchitt wants to merge 2 commits into
rdkcentral:developfrom
mahanteshchitt:migrate-to-ARM

Conversation

@mahanteshchitt

Copy link
Copy Markdown

Reason for change: Migrate scripts from BPI to ARM system ready
Test Procedure: Image should bootup and all functionality should work
Risks: Low

Reason for change: Migrate scripts from BPI to ARM system ready
Test Procedure: Image should bootup and all functionality should work
Risks: Low

Signed-off-by: mahanteshchitt <mahantesh_chittapur@comcast.com>
@mahanteshchitt mahanteshchitt self-assigned this Jun 22, 2026
@mahanteshchitt mahanteshchitt marked this pull request as ready for review July 13, 2026 14:37
@mahanteshchitt mahanteshchitt requested a review from a team as a code owner July 13, 2026 14:37
Copilot AI review requested due to automatic review settings July 13, 2026 14:37
@mahanteshchitt mahanteshchitt requested a review from a team as a code owner July 13, 2026 14:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ports existing “rpi/bpi”-specific init/service behaviors to a new BOX_TYPE=genericarm target to support ARM SystemReady images booting with the expected LAN/WAN/DHCP/mcast behavior.

Changes:

  • Extend multiple service scripts’ platform conditionals to treat genericarm similarly to rpi/bpi.
  • Update DHCP/LAN/forwarding flow gating so genericarm triggers the same lan-status and restart behavior paths.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
source/scripts/init/service.d/service_mcastproxy.sh Adds genericarm to igmpproxy launch logic for the expected platform branch.
source/scripts/init/service.d/service_ipv4.sh Ensures genericarm participates in rpi/bpi-specific lan-status handling.
source/scripts/init/service.d/service_forwarding.sh Aligns WAN/LAN restart behavior for genericarm with rpi/bpi handling.
source/scripts/init/service.d/service_dhcp_server/dhcp_server_functions.sh Includes genericarm in DHCP helper logic for starting lan-status under certain conditions.
source/scripts/init/service.d/service_dhcp_server.sh Extends DHCP-server start/retry and LAN refresh behaviors to genericarm.
source/scripts/init/service.d/lan_handler.sh Extends LAN init/start special-casing to include genericarm.
Comments suppressed due to low confidence (2)

source/scripts/init/service.d/service_mcastproxy.sh:120

  • The BOX_TYPE check is a very long chain of test expressions and mixes = and == under a #!/bin/sh script, which makes this branch harder to maintain and potentially less portable across /bin/sh implementations. A case statement is simpler and avoids repeated [ ... ] calls.
   if [ "$BOX_TYPE" = "HUB4" ] || [ "$BOX_TYPE" = "SR300" ] || [ "$BOX_TYPE" = "SE501" ] || [ "$BOX_TYPE" = "SR213" ] || [ "$BOX_TYPE" == "WNXL11BWL" ] || [ "$BOX_TYPE" == "rpi" ] || [ "$BOX_TYPE" == "bpi" ] || [ "$BOX_TYPE" == "genericarm" ] || [ "$BOX_TYPE" == "SCER11BEL" ] || [ "$BOX_TYPE" == "SCXF11BFL" ]; then
       $BIN $CONF_FILE &
   else 
       $BIN -c $CONF_FILE &
   fi

source/scripts/init/service.d/service_dhcp_server/dhcp_server_functions.sh:1140

  • By adding genericarm to this platform-specific block, the following bridge-mode check becomes relevant for that platform as well. The test [ $BRIDGE_MODE == 0 ] is not POSIX (==) and will also throw a syntax error if syscfg get bridge_mode returns an empty string (unquoted variable).
   if [ "$BOX_TYPE" = "rpi" ] || [ "$BOX_TYPE" = "bpi" ] || [ "$BOX_TYPE" = "turris" ] || [ "$BOX_TYPE" = "genericarm" ]; then
	   LAN_STATUS=`sysevent get lan-status`
	   BRIDGE_MODE=`syscfg get bridge_mode`
	   if [ "$LAN_STATUS" = "stopped" ] && [ $BRIDGE_MODE == 0 ]; then                
		   echo_t "DHCP_SERVER : Starting lan-status"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants