RDKCOM-5603: RDKBDEV-3455, RDKBACCL-1787 Upstreaming the utopia patches from meta-rdk-bsp-arm by mahanteshchitt · Pull Request #312 · rdkcentral/utopia

mahanteshchitt · 2026-05-12T10:51:07Z

Reason For Change: Upstreamed Generic ARM specific changes into common code to avoid maintaining platform patches.
Test Procedure: No utopia patches under meta-rdk-bsp-arm, should boot-up and should work as expected.
Risks: None
Priority: P0

A new platform GENERICARM is being introduced in RDK-B. Currently, to make the GENERICARM platform work similar to existing platforms like RPI and BPI, platform-specific changes are being maintained as patches in the meta-rdk-bsp-arm layer.

These patches add the required PLATFORM_FLAG handling (PLATFORM_GENERICARM_) and platform-specific behavior in utopia components, including firewall configuration, LAN handling, WAN handling, DHCP/DHCPv6 handling, IGD temporary path handling, and build fixes.

The goal of this work is to upstream these changes into the common/generic codebase so that GENERICARM support is available natively and the meta-rdk-bsp-arm layer becomes patch-free.

./meta-rdk-broadband/recipes-ccsp/util/utopia/0002-lan_handler-refresh-fix-lan-handler-for-rpi.patch.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0005-service_wan-use-_GENERIC_LINUX_DATA_PATH_-to-introdu.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0007-scripts-lan_handler-create-flag-files-for-lan-start-.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0010-RDKBDEV-XXXX-remove-usages-of-get_current_wan_ifname.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0011-service-dhcpv6_client-log-to-syslog-instead-of-dev-c.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0012-firewall-disable-mac-filter.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0008-dhcp-place-dnsmasq.conf-in-RAM-var-volatile.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0009-igd-place-IGD-temporary-files-under-var-volatile.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0006-scripts-utopia_init-do-nvram-restore_reboot-and-drop.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0001-scripts-lan_handler-treat-generic-Arm-boards-Ten64-q.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0013-scripts-fix-compile-errors-with-DNO_MTA_FEATURE_SUPP.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0004-firewall-use-_GENERIC_LINUX_DATA_PATH_-for-reference.patch
./meta-rdk-broadband/recipes-ccsp/util/utopia/0003-bridge-use-service_bridge_rpi-for-generic-arm-platfo.patch

these pathces includes adding firewall rules fo ARM device, adding platfrom flag i.e {}PLATFORM_GENERICARM and build time errors fixes.
Now we want make ARM as patch free build so , need to upstream to the generic code.

Actual Behavior

GENERICARM requires multiple downstream patches in meta-rdk-bsp-arm.
Without these patches:
Platform-specific code paths are not enabled.
Required firewall/LAN/WAN behavior is missing.
Build issues occur for some configurations.
Runtime behavior is inconsistent compared with other supported platforms.
Expected Behavior

GENERICARM should work similar to existing supported platforms (RPI/BPI).
Required platform-specific logic should be available in the common utopia code.
No additional utopia patches should be required from meta-rdk-bsp-arm.
build should complete successfully with GENERICARM configuration.

Reason For Change: Upstreamed Generic ARM specific changes into common code to avoid maintaining platform patches. Test Procedure: No utopia patches under meta-rdk-bsp-arm, should boot-up and should work as expected. Risks: None Signed-off-by: mahanteshchitt <mahantesh_chittapur@comcast.com>

Copilot

Pull request overview

Upstreams a set of Generic ARM platform patches (previously carried out-of-tree) into the shared Utopia codebase, primarily by aligning runtime paths (e.g., /var/volatile) and extending platform gating logic to include genericarm.

Changes:

Add _PLATFORM_GENERICARM_ / BOX_TYPE=genericarm handling across WAN, DHCP, IGD, init, and LAN handler flows.
Move several runtime artifacts for genericarm to /var/volatile (dnsmasq + IGD temp/web directories).
Extend firewall rule generation conditionals for genericarm (including MAP-T rule output interface selection and various feature gates).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
source/service_wan/service_wan.c	Treat genericarm like other embedded targets by skipping interface-down in one path and gating a refresh call.
source/service_dhcp/service_dhcp_server.c	Use `/var/volatile/dnsmasq.conf` for genericarm.
source/service_dhcp/dhcp_server_functions.c	Use `/var/volatile/dnsmasq.conf` for genericarm.
source/scripts/init/system/utopia_init.sh	Include `BOX_TYPE=genericarm` in model-based init behaviors (restore reboot reason, sshd start).
source/scripts/init/service.d/service_ipv4.sh	Include genericarm in the platform list that triggers LAN-status recovery behavior.
source/scripts/init/service.d/service_igd.sh	Use `/var/volatile/IGD` temp dir for genericarm.
source/scripts/init/service.d/service_dhcpv6_client.sh	Add targeted logging for genericarm callbacks.
source/scripts/init/service.d/service_dhcp_server/dhcp_server_functions.sh	Include genericarm in LAN-status/DHCP startup gating.
source/scripts/init/service.d/service_dhcp_server.sh	Use `/var/volatile/dnsmasq.conf` for genericarm and include genericarm in platform conditionals.
source/scripts/init/service.d/lan_handler.sh	Add genericarm compatibility shims and genericarm-specific LAN bring-up logic.
source/igd/src/igd_device_root.c	Use `/var/volatile/IGD` web dir for genericarm.
source/firewall/firewall.c	Add genericarm platform guards and use `current_wan_ifname` in some genericarm branches.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tinaelizabeth84 · 2026-07-16T17:25:35Z

@mahanteshchitt Please address the copilot review comments. if comment is not valid , we need to provide the explanation why it is not valid and resolve the comment.

Reason For Change: Upstreamed Generic ARM specific changes into common code to avoid maintaining platform patches. Test Procedure: No utopia patches under meta-rdk-bsp-arm, should boot-up and should work as expected. Risks: None Signed-off-by: mahanteshchitt <mahantesh_chittapur@comcast.com>

mahanteshchitt · 2026-07-17T07:46:49Z

@mahanteshchitt Please address the copilot review comments. if comment is not valid , we need to provide the explanation why it is not valid and resolve the comment.

addressed the copilot review commnets. @tinaelizabeth84

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

+   if [ "$BOX_TYPE" = "rpi" ] || [ "$BOX_TYPE" = "bpi" ] || [ "$BOX_TYPE" = "turris" ] || [ "$BOX_TYPE" = "genericarm" ]; then
 	   LAN_STATUS=`sysevent get lan-status`
 	   BRIDGE_MODE=`syscfg get bridge_mode`
 	   if [ "$LAN_STATUS" = "stopped" ] && [ $BRIDGE_MODE == 0 ]; then                


mahanteshchitt marked this pull request as ready for review June 25, 2026 11:11

mahanteshchitt requested a review from a team as a code owner June 25, 2026 11:11

Copilot AI review requested due to automatic review settings June 25, 2026 11:11

mahanteshchitt requested a review from a team as a code owner June 25, 2026 11:11

Merge branch 'develop' into upstream_chnages

fc0e041

Copilot started reviewing on behalf of mahanteshchitt June 25, 2026 11:12 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread source/firewall/firewall.c

Comment thread source/firewall/firewall.c Outdated

Comment thread source/firewall/firewall.c

Comment thread source/scripts/init/service.d/lan_handler.sh

mahanteshchitt changed the title ~~RDKBACCL-1787: Upstreaming the utopia patches from meta-rdk-bsp-arm~~ RDKBDEV-3455, RDKBACCL-1787: Upstreaming the utopia patches from meta-rdk-bsp-arm Jun 25, 2026

pradeeptakdas changed the title ~~RDKBDEV-3455, RDKBACCL-1787: Upstreaming the utopia patches from meta-rdk-bsp-arm~~ RDKCOM-5603: RDKBDEV-3455, RDKBACCL-1787 Upstreaming the utopia patches from meta-rdk-bsp-arm Jun 26, 2026

AkhilaReddyK7 added the community-contribution Contribution from community label Jun 30, 2026

Copilot AI review requested due to automatic review settings July 17, 2026 07:45

Copilot started reviewing on behalf of mahanteshchitt July 17, 2026 07:45 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread source/scripts/init/service.d/service_igd.sh Outdated

Comment thread source/scripts/init/service.d/service_dhcp_server.sh Outdated

Comment thread source/scripts/init/service.d/lan_handler.sh

Comment thread source/firewall/firewall.c Outdated

Merge branch 'develop' into upstream_chnages

5f46a85

Copilot AI review requested due to automatic review settings July 17, 2026 08:02

Copilot started reviewing on behalf of mahanteshchitt July 17, 2026 08:02 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread source/firewall/firewall.c Outdated

mahanteshchitt added 2 commits July 17, 2026 13:35

addressed the copilot review comments

24f4f02

addressed the copilet review comments

a577b7c

Copilot AI review requested due to automatic review settings July 17, 2026 08:14

Copilot started reviewing on behalf of mahanteshchitt July 17, 2026 08:15 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread source/firewall/firewall.c Outdated

Comment thread source/scripts/init/service.d/service_dhcp_server/dhcp_server_functions.sh

addrressed the copilot review comments

e8eafad

Copilot AI review requested due to automatic review settings July 17, 2026 08:25

Copilot started reviewing on behalf of mahanteshchitt July 17, 2026 08:25 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Uh oh!

Conversation

mahanteshchitt commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tinaelizabeth84 commented Jul 16, 2026

Uh oh!

mahanteshchitt commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mahanteshchitt commented May 12, 2026 •

edited

Loading