RDK-61871: Add OTEL source code and recipe changes to RDKE#511
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds TR-181/DML plumbing to control an OpenTelemetry/Distributed Tracing RFC flag from Device.DeviceInfo, including updating the WAL DB data model and implementing a setter that toggles a runtime flag file and the OTEL collector service.
Changes:
- Added new TR-181 parameter
Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.DistributedTracing.Enable. - Implemented a DeviceInfo RFC setter that starts/stops
rdk-otel-collector.serviceand creates/removes a tracing flag file. - Updated WAL DB data-model XMLs to expose the new object/parameter.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/hostif/profiles/DeviceInfo/Device_DeviceInfo.h | Adds macro definitions and declares the new RFC setter for DistributedTracing. |
| src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp | Routes the new RFC parameter to a new setter that toggles OTEL collector + flag file. |
| src/hostif/parodusClient/waldb/data-model/data-model-generic.xml | Adds the DistributedTracing object/Enable parameter to the generic data model. |
| src/hostif/parodusClient/waldb/data-model-generic.xml | Adds the DistributedTracing object/Enable parameter to the WALDB generic model root. |
Code Coverage Summary |
… restricting permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp:3922
- This setter always returns OK (ret is unconditionally set to OK at the end), even if creating/removing the flag file fails or if
systemctl start/stopfails. That can mislead callers into thinking the feature is enabled/disabled when the requested state change did not happen. Propagate failures by checkingopen/removeresults and the return code fromv_secure_system, and only return OK when the requested operations succeed.
ret = OK;
return ret;
Code Coverage Summary |
Code Coverage Summary |
shibu-kv
previously approved these changes
Jul 21, 2026
Code Coverage Summary |
1 similar comment
Code Coverage Summary |
nhanasi
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Add DML and handler for OTEL
Test Procedure: Build RDKE image
Signed-off-by: nc.aravindan@gmail.com