RDKEMW-14686-Wifi DataModel Params Retuning Empty Value on RDKE Builds#370
Open
Vismalskumar0 wants to merge 2 commits into
Open
RDKEMW-14686-Wifi DataModel Params Retuning Empty Value on RDKE Builds#370Vismalskumar0 wants to merge 2 commits into
Vismalskumar0 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where WiFi data model parameters were returning empty values on RDKE builds. The fix adds a strcpy_s call to populate the name member variable with the SSID value retrieved from the NetworkManager JSON-RPC response.
Changes:
- Added strcpy_s call to copy SSID value to the
namemember variable with appropriate error handling
Comments suppressed due to low confidence (2)
src/hostif/profiles/wifi/Device_WiFi_SSID.cpp:223
- Inconsistent indentation: This line uses a tab character for indentation that is inconsistent with the surrounding code style. The line should be indented with tabs and spaces matching the pattern used for the strcpy_s call on line 218 above it.
rc=strcpy_s(name,sizeof(name),ssid->valuestring);
src/hostif/profiles/wifi/Device_WiFi_SSID.cpp:226
- Inconsistent indentation: The ERR_CHK line has extra leading whitespace compared to the equivalent error handling on line 221 above. The indentation should match the pattern used in the surrounding code.
ERR_CHK(rc);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
approved these changes
Feb 27, 2026
Rebase and merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-14686-Wifi DataModel Params Retuning Empty Value on RDKE Builds
Reason for change:Copying the value so that the wifi name is populated correctly