Skip to content

RDKEMW-14686-Wifi DataModel Params Retuning Empty Value on RDKE Builds#370

Open
Vismalskumar0 wants to merge 2 commits into
developfrom
topic/RDKEMW-14686
Open

RDKEMW-14686-Wifi DataModel Params Retuning Empty Value on RDKE Builds#370
Vismalskumar0 wants to merge 2 commits into
developfrom
topic/RDKEMW-14686

Conversation

@Vismalskumar0

Copy link
Copy Markdown
Contributor

RDKEMW-14686-Wifi DataModel Params Retuning Empty Value on RDKE Builds

Reason for change:Copying the value so that the wifi name is populated correctly

@Vismalskumar0
Vismalskumar0 requested a review from a team as a code owner February 27, 2026 13:22
Copilot AI review requested due to automatic review settings February 27, 2026 13:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where WiFi data model parameters were returning empty values on RDKE builds. The fix adds a strcpy_s call to populate the name member variable with the SSID value retrieved from the NetworkManager JSON-RPC response.

Changes:

  • Added strcpy_s call to copy SSID value to the name member variable with appropriate error handling
Comments suppressed due to low confidence (2)

src/hostif/profiles/wifi/Device_WiFi_SSID.cpp:223

  • Inconsistent indentation: This line uses a tab character for indentation that is inconsistent with the surrounding code style. The line should be indented with tabs and spaces matching the pattern used for the strcpy_s call on line 218 above it.
			rc=strcpy_s(name,sizeof(name),ssid->valuestring);

src/hostif/profiles/wifi/Device_WiFi_SSID.cpp:226

  • Inconsistent indentation: The ERR_CHK line has extra leading whitespace compared to the equivalent error handling on line 221 above. The indentation should match the pattern used in the surrounding code.
                         ERR_CHK(rc);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants