RDKEMW-21510: Order Cryptography activation after PowerManager#249
Open
sergiygladkyy wants to merge 1 commit into
Open
RDKEMW-21510: Order Cryptography activation after PowerManager#249sergiygladkyy wants to merge 1 commit into
sergiygladkyy wants to merge 1 commit into
Conversation
Reason for change: - Backport of thunder-startup-services #240 (RDKEMW-19048) onto support/8.4.4.0 - The Cryptography plugin registers the IPowerManager mode-change handler in Initialize() with no retry on failure; if org.rdk.PowerManager is not active yet the registration fails silently and the deep-sleep SecAPI handle release never fires (RDKEMW-13788) - Require and order wpeframework-cryptography.service after wpeframework-powermanager.service; wpeframework.service stays required transitively Test Procedure: described in the ticket Implements: systemd unit dependency update Risks: Low Source: COMCAST License: Apache-2.0 Upstream-Status: Pending Signed-off-by: Sergiy Gladkyy <sgladkyy@productengine.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Backports a systemd unit ordering fix so the org.rdk.Cryptography plugin is activated only after org.rdk.PowerManager, preventing missed IPowerManager mode-change handler registration when PowerManager isn’t yet active.
Changes:
- Updates
wpeframework-cryptography.servicetoRequires=andAfter=wpeframework-powermanager.serviceinstead ofwpeframework.service. - Ensures Cryptography activation is sequenced behind PowerManager (and transitively behind
wpeframework.service, since PowerManager requires it).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change
Backport of #240 (RDKEMW-19048) onto
support/8.4.4.0.The Cryptography plugin registers an
IPowerManagermode-change handler inCryptographyExtAccess::Initialize()with no retry on failure. Iforg.rdk.PowerManageris not active whenorg.rdk.Cryptographyinitializes, the registration fails silently and the deep-sleep SecAPI handle release never fires (RDKEMW-13788).Requires and orders
wpeframework-cryptography.serviceafterwpeframework-powermanager.service;wpeframework.servicestays required transitively.Test Procedure
Described in the ticket: standby/wake with Network Standby OFF; confirm
org.rdk.Cryptographyactivates afterorg.rdk.PowerManagerand the handler registration succeeds in the logs.Risks
Low