RDKEMW-20801: widen OCDM auto-start window to ~200s (-r 250 -d 800)#248
Open
nanimatta wants to merge 2 commits into
Open
RDKEMW-20801: widen OCDM auto-start window to ~200s (-r 250 -d 800)#248nanimatta wants to merge 2 commits into
nanimatta wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Increases the WPEFramework OCDM plugin activation auto-start retry count to improve resiliency when OCDM is not immediately available during boot.
Changes:
- Updated the
wpeframework-ocdm.serviceExecStartinvocation to use a higher retry count (-r 400instead of-r 200).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=/usr/bin/PluginActivator -r 200 OCDM | ||
| ExecStart=/usr/bin/PluginActivator -r 250 -d 800 OCDM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-line variant of #246 for
support/8.3.4.0(the 8.3.4.15 ship). Same one-line change.Reason for change
-r 200, ~101s) can expire before the PROVISIONING precondition is met, failing the unit and taking the WPEFramework target down.uint8_t(caps at 255), so the delay is the lever:-r 250 -d 800. (-r 400wraps to 144, shorter than stock.)-r 200the same way.Test Procedure
Described in the ticket: FSR then connect with provisioning delayed past ~130s; confirm
wpeframework-ocdm.servicereachesactive (exited)rather thanfailed.Risks
No. Healthy boots break the poll on first successful activation; the wider window is only used on the slow-provisioning path.