Skip to content

Get the pipeline position instead of video sink position when syncing the subtitles#559

Merged
skywojciechowskim merged 1 commit into
masterfrom
feature/RDKEMW-21216
Jul 14, 2026
Merged

Get the pipeline position instead of video sink position when syncing the subtitles#559
skywojciechowskim merged 1 commit into
masterfrom
feature/RDKEMW-21216

Conversation

@skywojciechowskim

Copy link
Copy Markdown
Contributor

Summary: Get the pipeline position instead of video sink position when syncing the subtitles
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-21216

Copilot AI review requested due to automatic review settings July 13, 2026 09:26
@github-actions

Copy link
Copy Markdown

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes subtitle synchronization by using the pipeline position (via IGstGenericPlayerPrivate::getPosition) instead of querying the video sink position when emitting the current-pts event to the subtitle source.

Changes:

  • Query playback position from the pipeline (m_context.pipeline) rather than m_context.videoSink.
  • Early-return when position retrieval fails (instead of continuing with a default/previous value).
  • Keep sending a current-pts custom downstream OOB event to the subtitle appsrc for sync.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

@skywojciechowskim
skywojciechowskim merged commit 4e03141 into master Jul 14, 2026
64 of 67 checks passed
@skywojciechowskim
skywojciechowskim deleted the feature/RDKEMW-21216 branch July 14, 2026 06:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants