RDKEMW-18434 : [BCM Rogers Monarch IUI V2] RialtoServer process crash observed while switching between Xumo FAST channels during CC verification

[rekhap2kandhavelan]

Summary: handling race conditions for GstPlayer
Type: Fix
Test Plan: UT/CT, Fullstac
Jira: RDKEMW-18434

[github-actions]

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

[Copilot]

Pull request overview

This PR aims to prevent RialtoServer crashes seen during FAST channel switching by reducing teardown-time races between the GStreamer player (timers/worker thread) and MediaPipelineServer client notifications.

Changes:

• Adjusts playback-info notification behavior to avoid acting on invalid/tearing-down player state.
• Attempts to stop periodic playback-info notifications during pipeline termination.
• Relaxes a unit-test teardown expectation to tolerate additional timer interactions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tests/unittests/media/server/gstplayer/genericPlayer/common/GstGenericPlayerTestCommon.cpp	Loosens timer factory expectations during GstGenericPlayer destruction in unit tests.
media/server/main/source/MediaPipelineServerInternal.cpp	Adds additional gating/logging around playback-info notification and includes a minor formatting-only change.
media/server/gstplayer/source/GstGenericPlayer.cpp	Stops periodic playback-info notifications during pipeline termination.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

tests/unittests/media/server/gstplayer/genericPlayer/GstGenericPlayerPrivateTest.cpp:1709

• The continuation line for this EXPECT_CALL chain is tab-indented; align it with the surrounding call chains (spaces) for consistency.

        .WillOnce(Return(ByMove(std::move(timerMock))));

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

[github-actions]

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 0.0% to 81.7%
Congratulations, your commit improved functions coverage from: 0.0% to 91.3%

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[github-actions]

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 0.0% to 84.3%
Congratulations, your commit improved functions coverage from: 0.0% to 92.5%

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.