RDKEMW-18434 : [BCM Rogers Monarch IUI V2] RialtoServer process crash observed while switching between Xumo FAST channels during CC verification.#553
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
Pull request overview
Fixes a reported RialtoServer crash during rapid FAST channel switching by adjusting teardown/notification behavior around GstPlayer to mitigate race conditions between worker-thread callbacks and main-thread task dispatch.
Changes:
- Updates
MediaPipelineServerInternaldestructor teardown sequence to explicitly destroym_gstPlayer. - Adds additional guarding/logging around
notifyPlaybackInfo()whenm_gstPlayeris not valid.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| m_shmBuffer.reset(); | ||
| m_mainThread->unregisterClient(m_mainThreadClientId); | ||
|
|
||
| // Destroy GstPlayer first, while the main thread client is still registered. | ||
| // This ensures that during the worker thread drain in ~GstGenericPlayer, |
|
Coverage statistics of your commit: |
83a84d1 to
1036195
Compare
|
Coverage statistics of your commit: |
|
Coverage statistics of your commit: |
|
CCI-Build-Verified -1 |
|
Coverage statistics of your commit: |
Summary: handling race conditions for GstPlayer
Type: Fix
Test Plan: UT/CT, Fullstac
Jira: RDKEMW-18434