RDKEMW-19064: Implementation of OCDM api's to be able to query Key Sy… by kkanag314 · Pull Request #545 · rdkcentral/rialto

kkanag314 · 2026-06-26T07:05:05Z

Summary: Implement a interfaces in webkit to query the robustness level from CDM
Type: Feature
Test Plan:Check the Widevine L1 DRM support on Glass/Stream with the test URL and regression testing of webapps
Jira: https://ccp.sys.comcast.net/browse/RDKEMW-19064

…stem Robustness Level Reason for change: Implement a interfaces in webkit to query the robustness level from CDM Test Procedure: Check the Widevine L1 DRM support on Glass/Stream with the test URL and regression tsting of webapps Priority: P1 Risks: None

github-actions · 2026-06-26T07:05:18Z

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

github-actions · 2026-06-26T07:05:47Z

media/client/ipc/source/MediaKeysCapabilitiesIpc.cpp:251:1: error: Unmatched '}'. Configuration: ''. [syntaxError]
}; // namespace firebolt::rialto::client
^
nofile:0:0: information: Active checkers: There was critical errors (use --checkers-report= to see details) [checkersReport]

Copilot

Pull request overview

This PR adds an end-to-end API (wrapper → server service → IPC → client) to query the robustness levels supported by the underlying CDM for a given key system, enabling WebKit (and other consumers) to determine DRM robustness (e.g., Widevine L1 support).

Changes:

Added getSupportedRobustnessLevels to the public/media capabilities interfaces and implementations (client + server).
Extended the MediaKeysCapabilities IPC protobuf/service with a new getSupportedRobustnessLevels RPC.
Implemented the OpenCDM wrapper call to retrieve supported robustness levels from the CDM.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
wrappers/source/OcdmSystem.cpp	Adds OpenCDM wrapper method to retrieve robustness levels from the system handle.
wrappers/interface/IOcdmSystem.h	Exposes robustness-level query in the wrapper interface.
wrappers/include/OcdmSystem.h	Declares the new wrapper method on `OcdmSystem`.
media/server/main/source/MediaKeysCapabilities.cpp	Implements server-side robustness-level query via `IOcdmSystemFactory`.
media/server/main/include/MediaKeysCapabilities.h	Declares the new server-side capabilities method.
media/server/service/source/CdmService.cpp	Adds `ICdmService` entrypoint forwarding to MediaKeysCapabilities.
media/server/service/source/CdmService.h	Declares the new `ICdmService` override on `CdmService`.
media/server/service/include/ICdmService.h	Extends the service interface with the new query method.
media/server/ipc/source/MediaKeysCapabilitiesModuleService.cpp	Implements the new protobuf RPC on the server.
media/server/ipc/include/MediaKeysCapabilitiesModuleService.h	Declares the new protobuf RPC handler.
media/client/ipc/source/MediaKeysCapabilitiesIpc.cpp	Implements client-side IPC call + response unmarshalling.
media/client/ipc/include/MediaKeysCapabilitiesIpc.h	Declares the client IPC method.
media/client/main/source/MediaKeysCapabilities.cpp	Adds client-side convenience method forwarding to IPC.
media/client/main/include/MediaKeysCapabilities.h	Declares the new client capabilities method.
media/public/include/IMediaKeysCapabilities.h	Extends the public client-facing interface with the new method.
proto/mediakeyscapabilitiesmodule.proto	Adds request/response messages + RPC for robustness levels.
patch.patch	Adds a tracked git-format patch file containing the same changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+From feda9d75dd606ac48286909115c4f81015431755 Mon Sep 17 00:00:00 2001
+From: Krishna Priya Kanagaraj <krishnapriya_kanagaraj@comcast.com>
+Date: Tue, 26 May 2026 11:59:42 +0000
+Subject: [PATCH] add getSupportedRobustnessLevels to rialto
+


github-actions · 2026-06-26T07:11:35Z

media/client/ipc/source/MediaKeysCapabilitiesIpc.cpp:251:1: error: Unmatched '}'. Configuration: ''. [syntaxError]
}; // namespace firebolt::rialto::client
^
nofile:0:0: information: Active checkers: There was critical errors (use --checkers-report= to see details) [checkersReport]

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)


Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 4 comments.

+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


+bool CdmService::getSupportedRobustnessLevels(const std::string &keySystem, std::vector<std::string> &robustnessLevels)
+{
+    RIALTO_SERVER_LOG_DEBUG("CdmService requested to getSupportedRobustnessLevels");
+


+bool MediaKeysCapabilitiesIpc::getSupportedRobustnessLevels(const std::string &keySystem,
+                                                            std::vector<std::string> &robustnessLevels)
+{
+    if (!reattachChannelIfRequired())
+    {
+        RIALTO_CLIENT_LOG_ERROR("Reattachment of the ipc channel failed, ipc disconnected");
+        return false;
+    }


+    /**
+     * @brief Gets the robustness levels supported by the underlying CDM for this key system.
+     *
+     * @param[out] robustnessLevels : The supported robustness levels.
+     *
+     * @retval true if robustness levels were retrieved successfully
+     */
+    virtual bool getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels) = 0;
+


Copilot

Pull request overview

Copilot reviewed 44 out of 44 changed files in this pull request and generated 4 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


+From af88d9a3d6afda7671bee13f4139d17a767cd5c5 Mon Sep 17 00:00:00 2001
+From: Krishna Priya Kanagaraj <krishnapriya_kanagaraj@comcast.com>
+Date: Fri, 10 Jul 2026 01:56:56 +0530
+Subject: [PATCH] clang fix


+bool MediaKeysCapabilitiesIpc::getSupportedRobustnessLevels(const std::string &keySystem,
+                                                            std::vector<std::string> &robustnessLevels)
+{
+    if (!reattachChannelIfRequired())
+    {
+        RIALTO_CLIENT_LOG_ERROR("Reattachment of the ipc channel failed, ipc disconnected");
+        return false;
+    }


+    MediaKeysTestMethods::shouldNotGetSupportedRobustnessLevels();
+    MediaKeysTestMethods::doesNotGetSupportedRobustnessLevels();
+
+    // Step 11: Destroy MediaKeysCabilities.


github-actions · 2026-07-10T07:48:11Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

Copilot

Pull request overview

Copilot reviewed 43 out of 58 changed files in this pull request and generated 3 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


+bool MediaKeysCapabilitiesIpc::getSupportedRobustnessLevels(const std::string &keySystem,
+                                                            std::vector<std::string> &robustnessLevels)
+{
+    if (!reattachChannelIfRequired())
+    {
+        RIALTO_CLIENT_LOG_ERROR("Reattachment of the ipc channel failed, ipc disconnected");
+        return false;
+    }


+bool CdmService::getSupportedRobustnessLevels(const std::string &keySystem, std::vector<std::string> &robustnessLevels)
+{
+    RIALTO_SERVER_LOG_DEBUG("CdmService requested to getSupportedRobustnessLevels");
+
+    if (!m_isActive)
+    {
+        RIALTO_SERVER_LOG_ERROR("Skip getSupportedRobustnessLevels: Session Server in Inactive state");
+        return false;
+    }


Copilot

Pull request overview

Copilot reviewed 43 out of 58 changed files in this pull request and generated 3 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


+bool MediaKeysCapabilitiesIpc::getSupportedRobustnessLevels(const std::string &keySystem,
+                                                            std::vector<std::string> &robustnessLevels)
+{
+    if (!reattachChannelIfRequired())
+    {
+        RIALTO_CLIENT_LOG_ERROR("Reattachment of the ipc channel failed, ipc disconnected");
+        return false;
+    }


+    MediaKeysTestMethods::shouldNotGetSupportedRobustnessLevels();
+    MediaKeysTestMethods::doesNotGetSupportedRobustnessLevels();
+
+    // Step 11: Destroy MediaKeysCabilities.


Copilot

Pull request overview

Copilot reviewed 43 out of 58 changed files in this pull request and generated 3 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


+    MediaKeysTestMethods::shouldNotGetSupportedRobustnessLevels();
+    MediaKeysTestMethods::doesNotGetSupportedRobustnessLevels();
+
+    // Step 11: Destroy MediaKeysCabilities.


+    auto mediaKeysCapabilities = m_mediaKeysCapabilitiesFactory->getMediaKeysCapabilities();
+    if (!mediaKeysCapabilities)
+    {
+        RIALTO_SERVER_LOG_ERROR("MediaKeysCapabilities is null");
+        return false;
+    }


github-actions · 2026-07-10T10:18:20Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

github-actions · 2026-07-10T10:30:49Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

Copilot

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 3 comments.

+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


 #include "opencdm/open_cdm_ext.h"
 #include <stdexcept>

+extern "C" OpenCDMError opencdm_system_supported_robustness(struct OpenCDMSystem *system, char ***robustness,
+                                                            uint16_t *count);


+    MediaKeysTestMethods::shouldNotGetSupportedRobustnessLevels();
+    MediaKeysTestMethods::doesNotGetSupportedRobustnessLevels();
+
+    // Step 11: Destroy MediaKeysCabilities.


Copilot

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 4 comments.

+extern "C" OpenCDMError opencdm_system_supported_robustness(struct OpenCDMSystem *system, char ***robustness,
+                                                            uint16_t *count);


+bool OcdmSystem::getSupportedRobustnessLevels(std::vector<std::string> &robustnessLevels)
+{
+    robustnessLevels.clear();
+    char **buffer = nullptr;
+    uint16_t count = 0;
+    OpenCDMError status = opencdm_system_supported_robustness(m_systemHandle, &buffer, &count);
+    if (status == ERROR_NONE && buffer != nullptr && count > 0)
+    {
+        for (uint16_t i = 0; i < count; ++i)
+        {
+            if (buffer[i] != nullptr)
+            {
+                robustnessLevels.push_back(std::string(buffer[i]));
+                free(buffer[i]);
+            }
+        }
+        free(buffer);
+        return true;
+    }
+    if (buffer != nullptr)
+    {
+        free(buffer);
+    }
+    return false;
+}


+bool MediaKeysCapabilitiesIpc::getSupportedRobustnessLevels(const std::string &keySystem,
+                                                            std::vector<std::string> &robustnessLevels)
+{
+    if (!reattachChannelIfRequired())
+    {
+        RIALTO_CLIENT_LOG_ERROR("Reattachment of the ipc channel failed, ipc disconnected");
+        return false;
+    }


+    MediaKeysTestMethods::shouldNotGetSupportedRobustnessLevels();
+    MediaKeysTestMethods::doesNotGetSupportedRobustnessLevels();
+
+    // Step 11: Destroy MediaKeysCabilities.


github-actions · 2026-07-14T12:25:53Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.3%
Functions coverage stays unchanged and is: 92.7%

Copilot AI review requested due to automatic review settings June 26, 2026 07:05

Copilot started reviewing on behalf of kkanag314 June 26, 2026 07:05 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Delete patch.patch

3a90d15

Apply suggestions from code review

411e658

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 29, 2026 15:30

Copilot started reviewing on behalf of kkanag314 June 29, 2026 15:30 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Apply suggestions from code review

0928ad9

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 29, 2026 18:24

Copilot started reviewing on behalf of kkanag314 June 29, 2026 18:24 View session

Apply suggestions from code review

7746e90

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 29, 2026 18:28

Copilot started reviewing on behalf of kkanag314 June 29, 2026 18:29 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

kkanag314 and others added 2 commits July 1, 2026 00:00

Merge branch 'master' into RDKEMW-19064

7cab4a6

add unit test cases

7e11abe

Copilot AI review requested due to automatic review settings July 2, 2026 06:39

Copilot started reviewing on behalf of kkanag314 July 2, 2026 06:39 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Merge branch 'master' into RDKEMW-19064

dd00439

Copilot AI review requested due to automatic review settings July 9, 2026 16:19

Copilot started reviewing on behalf of kkanag314 July 9, 2026 16:20 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

resolve ci failure

621f1c5

Copilot AI review requested due to automatic review settings July 10, 2026 07:27

Copilot started reviewing on behalf of kkanag314 July 10, 2026 07:27 View session