Skip to content

Update L2-tests.yml#195

Open
Abhinavpv28 wants to merge 2 commits into
developfrom
feature/dummy_L2
Open

Update L2-tests.yml#195
Abhinavpv28 wants to merge 2 commits into
developfrom
feature/dummy_L2

Conversation

@Abhinavpv28

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 21, 2026 09:09
@Abhinavpv28
Abhinavpv28 requested a review from a team as a code owner April 21, 2026 09:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflow that runs L2 integration tests on pull requests by modifying which target branches trigger the workflow.

Changes:

  • Expanded the pull_request base-branch filter to include feature/dummy_L2 in .github/workflows/L2-tests.yml.

on:
pull_request:
branches: [ develop, main ]
branches: [ develop, main, feature/dummy_L2 ]

Copilot AI Apr 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on.pull_request.branches filters the PR base branch (the branch being merged into), not the source branch. Adding feature/dummy_L2 will cause this workflow to run for PRs that target that branch; if the intent was to run L2 only when the PR comes from feature/dummy_L2 (or to keep running only for PRs into develop/main), this change won’t achieve that and may increase CI runs unexpectedly. Consider removing this branch from the trigger, or add a job-level condition using github.head_ref / github.base_ref to match the intended behavior.

Suggested change
branches: [ develop, main, feature/dummy_L2 ]
branches: [ develop, main ]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants