Update rfc_xconf_handler.cpp by nhanasi · Pull Request #185 · rdkcentral/rfc

nhanasi · 2026-03-09T16:00:50Z

No description provided.

Copilot

Pull request overview

This PR updates RuntimeFeatureControlProcessor::clearDB() to pass arguments to set_RFCProperty using std::move, presumably to reduce string copies when writing TR-181/RFC backing-store values.

Changes:

Replaced three set_RFCProperty(name, key, value) calls with set_RFCProperty(std::move(...), ...) in clearDB().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-09T16:03:21Z

+    set_RFCProperty(std::move(name), std::move(ClearDB), std::move(clearValue));
+    set_RFCProperty(std::move(name), std::move(BootstrapClearDB), std::move(clearValue));
+    set_RFCProperty(std::move(name), std::move(ConfigChangeTimeKey), std::move(ConfigChangeTime));


std::move(name) is used in the first set_RFCProperty call and then name is moved again in subsequent calls. After the first move, name is left in a moved-from state (typically empty), so the later set_RFCProperty calls may write to an invalid/empty namespace and fail. Use name normally (no move) or create separate copies for each call / change set_RFCProperty to take const std::string&/std::string_view if you’re trying to avoid copies.

Suggested change

set_RFCProperty(std::move(name), std::move(ClearDB), std::move(clearValue));

set_RFCProperty(std::move(name), std::move(BootstrapClearDB), std::move(clearValue));

set_RFCProperty(std::move(name), std::move(ConfigChangeTimeKey), std::move(ConfigChangeTime));

set_RFCProperty(name, ClearDB, clearValue);

set_RFCProperty(name, BootstrapClearDB, clearValue);

set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);

Copilot · 2026-03-09T16:03:21Z

+    set_RFCProperty(std::move(name), std::move(ClearDB), std::move(clearValue));
+    set_RFCProperty(std::move(name), std::move(BootstrapClearDB), std::move(clearValue));
+    set_RFCProperty(std::move(name), std::move(ConfigChangeTimeKey), std::move(ConfigChangeTime));

    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());


ClearDB, BootstrapClearDB, ConfigChangeTimeKey, and ConfigChangeTime are moved into set_RFCProperty and then immediately used afterwards in log statements. This will typically log empty strings (moved-from state) and makes debugging harder. Either avoid moving these variables or log before moving / keep separate variables for logging.

rdkcmf-jenkins · 2026-03-09T16:11:38Z

Coverity Issue - Using a moved object

"ConfigChangeTime" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
rfcMgr/rfc_xconf_handler.cpp:1308

rdkcmf-jenkins · 2026-03-09T16:11:38Z

+    set_RFCProperty(std::move(name), std::move(BootstrapClearDB), std::move(clearValue));
+    set_RFCProperty(std::move(name), std::move(ConfigChangeTimeKey), std::move(ConfigChangeTime));

    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Using a moved object

"ClearDB" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

rdkcmf-jenkins · 2026-03-09T16:11:38Z

-    set_RFCProperty(name, BootstrapClearDB, clearValue);
-    set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);
+    set_RFCProperty(std::move(name), std::move(ClearDB), std::move(clearValue));
+    set_RFCProperty(std::move(name), std::move(BootstrapClearDB), std::move(clearValue));


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Using a moved object

"name" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

rdkcmf-jenkins · 2026-03-09T16:11:38Z

+    set_RFCProperty(std::move(name), std::move(ConfigChangeTimeKey), std::move(ConfigChangeTime));

    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());
    RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DB Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDB.c_str());


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Using a moved object

"BootstrapClearDB" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

rdkcmf-jenkins · 2026-03-09T16:11:38Z

-    set_RFCProperty(name, BootstrapClearDB, clearValue);
-    set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);
+    set_RFCProperty(std::move(name), std::move(ClearDB), std::move(clearValue));
+    set_RFCProperty(std::move(name), std::move(BootstrapClearDB), std::move(clearValue));


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Using a moved object

"clearValue" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

rdkcmf-jenkins · 2026-03-09T16:43:58Z

+	std::string clearValue_mv(std::move(clearValue));
+
+	set_RFCProperty(name_mv, std::move(ClearDB), clearValue_mv);
+    set_RFCProperty(name_mv, std::move(BootstrapClearDB), clearValue_mv);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"clearValue_mv" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""clearValue_mv"")" instead of "clearValue_mv".

rdkcmf-jenkins · 2026-03-09T16:43:58Z

+
+	set_RFCProperty(name_mv, std::move(ClearDB), clearValue_mv);
+    set_RFCProperty(name_mv, std::move(BootstrapClearDB), clearValue_mv);
+    set_RFCProperty(name_mv, std::move(ConfigChangeTimeKey), std::move(ConfigChangeTime));


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"name_mv" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""name_mv"")" instead of "name_mv".

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-09T17:49:27Z

-    set_RFCProperty(name, ClearDB, clearValue);
-    set_RFCProperty(name, BootstrapClearDB, clearValue);
-    set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);
+	set_RFCProperty(name, ClearDB, std::move(clearValue));


Indentation on this line uses a tab while surrounding lines use spaces, which makes formatting inconsistent. Align indentation with the existing spacing style in this function/file.

Suggested change

set_RFCProperty(name, ClearDB, std::move(clearValue));

set_RFCProperty(name, ClearDB, std::move(clearValue));

rdkcmf-jenkins · 2026-03-09T17:59:26Z

-    set_RFCProperty(name, BootstrapClearDB, clearValue);
-    set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);
+	set_RFCProperty(name, ClearDB, std::move(clearValue));
+    set_RFCProperty(name, BootstrapClearDB, std::move(clearValue));


Coverity Issue - Using a moved object

"clearValue" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

Update rfc_xconf_handler.cpp

209890e

nhanasi requested a review from a team as a code owner March 9, 2026 16:00

Copilot AI review requested due to automatic review settings March 9, 2026 16:00

Copilot started reviewing on behalf of nhanasi March 9, 2026 16:01 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

rdkcmf-jenkins reviewed Mar 9, 2026

View reviewed changes

Update rfc_xconf_handler.cpp

0ac50d4

rdkcmf-jenkins reviewed Mar 9, 2026

View reviewed changes

Update rfc_xconf_handler.cpp

0144772

Copilot AI review requested due to automatic review settings March 9, 2026 17:47

Copilot started reviewing on behalf of nhanasi March 9, 2026 17:47 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

rdkcmf-jenkins reviewed Mar 9, 2026

View reviewed changes

	set_RFCProperty(name, ClearDB, std::move(clearValue));
	set_RFCProperty(name, ClearDB, std::move(clearValue));

Uh oh!

Conversation

nhanasi commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Using a moved object

Issue location

Uh oh!

rdkcmf-jenkins Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Using a moved object

Uh oh!

rdkcmf-jenkins Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Using a moved object

Uh oh!

rdkcmf-jenkins Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Using a moved object

Uh oh!

rdkcmf-jenkins Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Using a moved object

Uh oh!

rdkcmf-jenkins Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Mar 9, 2026

Choose a reason for hiding this comment

Coverity Issue - Using a moved object

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rdkcmf-jenkins commented Mar 9, 2026 •

edited

Loading

rdkcmf-jenkins Mar 9, 2026 •

edited

Loading

rdkcmf-jenkins Mar 9, 2026 •

edited

Loading

rdkcmf-jenkins Mar 9, 2026 •

edited

Loading

rdkcmf-jenkins Mar 9, 2026 •

edited

Loading

rdkcmf-jenkins Mar 9, 2026 •

edited

Loading

rdkcmf-jenkins Mar 9, 2026 •

edited

Loading