Fix memory leak in DownloadRuntimeFeatutres from early return paths#164
Merged
Conversation
…tern Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
…n cleanup Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update rfc_xconf_handler.cpp based on PR #163 feedback
Fix memory leak in DownloadRuntimeFeatutres from early return paths
Jan 30, 2026
Vismalskumar0
marked this pull request as ready for review
January 30, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DownloadRuntimeFeatutresfunction allocatedhashParamand itsstrdup'd members (hashvalue,hashtime) but had multiple early return paths that bypassed cleanup, leaking memory on cert selector failures and MTLS cert fetch failures.Changes
goto cleanuppatternhashParammembers tonullptrimmediately after allocation for safe cleanupgoto cleanupBefore
After
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.