RRD 1.3.6 release changelog updates#215
Closed
nhanasi wants to merge 3 commits into
Closed
Conversation
RRD release for 1.3.5 version
…is leading RDM crash (#211) * Update rrd_config.c * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Update rrd_config.c * Update rrd_config.c * Update rrd_config.c * Update rrd_config.c --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Code Coverage Summary |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates release documentation for RRD 1.3.6, and includes a small behavior change in configuration file detection used by the C implementation of the uploadRRDLogs flow.
Changes:
- Add a new
1.3.6section toCHANGELOG.mdand add a release date line for1.3.5. - Tighten
file_exists()insrc/rrd_config.cto require a regular file and (currently) non-zero size.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/rrd_config.c |
Changes the helper used to detect config/tool files during configuration loading. |
CHANGELOG.md |
Adds the 1.3.6 release notes and adjusts release metadata formatting. |
Comment on lines
+82
to
+86
| // Helper: check if file exists and has non-zero size | ||
| static bool file_exists(const char *filepath) { | ||
| if (!filepath) return false; | ||
| struct stat st; | ||
| return (stat(filepath, &st) == 0); | ||
| return (stat(filepath, &st) == 0 && S_ISREG(st.st_mode) && st.st_size > 0); |
Comment on lines
+7
to
+8
| #### [1.3.6](https://github.com/rdkcentral/remote_debugger/compare/1.3.5...1.3.6) | ||
|
|
|
|
||
| #### [1.3.6](https://github.com/rdkcentral/remote_debugger/compare/1.3.5...1.3.6) | ||
|
|
||
| - RDKEMW-17573: Triggering a issue type with more than 35 chars in RRD is leading RDM crash [`#211`](https://github.com/rdkcentral/remote_debugger/pull/211) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.