Update rdke-distros.inc#142
Conversation
By default enabled distro "build_external_player_interface" inorder to use the middleware-player-interface repository for aamp playbacks
There was a problem hiding this comment.
Pull request overview
This PR updates the RDK-E distro feature configuration to enable build_external_player_interface by default, intended to support AAMP playback via the middleware-player-interface repository.
Changes:
- Add
build_external_player_interfacetoDISTRO_FEATURESin the default distro feature set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DISTRO_FEATURES:append = ' enable_app_gateway' | ||
| DISTRO_FEATURES:append = ' apparmor_segmented_global' | ||
| DISTRO_FEATURES:append = ' rdkwindowmanager' | ||
| DISTRO_FEATURES:append = ' build_external_player_interface' |
There was a problem hiding this comment.
build_external_player_interface is added to DISTRO_FEATURES, but this feature string is not referenced anywhere else in this repository (no bb.utils.contains('DISTRO_FEATURES', 'build_external_player_interface', ...) / DISTRO_FEATURES:contains(...) usage). If the intent is to switch AAMP playback to middleware-player-interface, please add the corresponding conditional logic in this repo or document/point to the layer/recipe that consumes this flag; otherwise this change is a no-op relative to the stated PR purpose.
By default enabled distro "build_external_player_interface" inorder to use the middleware-player-interface repository for aamp playbacks