RDKEMW-12539: Fix for Avoid hardcoding of widget names in pre-install manager#115
RDKEMW-12539: Fix for Avoid hardcoding of widget names in pre-install manager#115devasena18 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a configurable BitBake variable for the preinstall packages directory to avoid embedding the path in consuming components.
Changes:
- Introduces
APP_PREINSTALL_DIRECTORYwith a default value in the common RDK-E config include.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #Removing fstackprotector and fortify source | ||
| SECURITY_CFLAGS:remove = " -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wno-error=format-security -Wno-error=unused-result" | ||
| SECURITY_LDFLAGS:remove = " -fstack-protector" | ||
| APP_PREINSTALL_DIRECTORY ?= "/var/sky/packages" |
There was a problem hiding this comment.
APP_PREINSTALL_DIRECTORY is set with ?= here, but conf/rdke-rdkm-config.inc also sets the same variable with ?= (line ~53). If both configs are included, the first ?= wins and the RDKM-specific default (/media/apps) would no longer apply. Consider switching this to ??= (weaker default) or updating the RDKM file to use an explicit override (e.g., = or a distro/machine override) so platform-specific defaults still take effect.
| APP_PREINSTALL_DIRECTORY ?= "/var/sky/packages" | |
| APP_PREINSTALL_DIRECTORY ??= "/var/sky/packages" |
There was a problem hiding this comment.
This file for community use. OEM specific changes should in comcast private repos.
madanagopalt
left a comment
madanagopalt
left a comment
There was a problem hiding this comment.
Let's use explict assignment instead of ?=
| #Removing fstackprotector and fortify source | ||
| SECURITY_CFLAGS:remove = " -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wno-error=format-security -Wno-error=unused-result" | ||
| SECURITY_LDFLAGS:remove = " -fstack-protector" | ||
| APP_PREINSTALL_DIRECTORY ?= "/var/sky/packages" |
There was a problem hiding this comment.
This file for community use. OEM specific changes should in comcast private repos.
No description provided.