RDKBACCL-1509: [TDK][AUTO][BPI] Firmware upgrade via Xconf fails if the HTTP image hosting server does not listen to the default 80 port#9
Draft
ksaipr036 wants to merge 1 commit into
Conversation
…he HTTP image hosting server does not listen to the default 80 port Reason for Change: Firmware upgrade fails when the image is hosted on an HTTP server listening on a non-default port (other than port 80). Test Procedure: 1. Use a download URL with only IP (no explicit port, defaults to 80). 2. Verify that both TFTP and HTTP firmware upgrade work as expected. Risks: Low. Signed-off-by: ksaipr036 <kosika_saipriya@comcast.com>
ksaipr036
force-pushed
the
RDKBACCL-1509
branch
from
March 30, 2026 13:18
979a5fd to
a70cc6e
Compare
|
Looks okay to me |
cpokuru
requested changes
Mar 31, 2026
| snprintf(cmd, sizeof(cmd), | ||
| "dmcli eRT setv Device.DeviceInfo.X_RDKCENTRAL-COM_FirmwareDownloadURL string \"%s://%s:%d\"", | ||
| g_firmwareProtocol, g_firmwareLocation, port_num); | ||
| "dmcli eRT setv Device.DeviceInfo.X_RDKCENTRAL-COM_FirmwareDownloadURL string \"%s://%s\"", |
Contributor
There was a problem hiding this comment.
why hal is depending on rdk-b ??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Firmware upgrade fails when the image is hosted on an HTTP server listening on a non-default port (other than port 80).
Test Procedure:
Risks: Low.