RDKBACCL-1940 : Firmware Upgrade is not working#10
Open
anatar818 wants to merge 4 commits into
Open
Conversation
Refactor MAC command to use dynamic interface name from wan_name.txt.
Removed unused variable 'path' from fwupgrade_hal.c
There was a problem hiding this comment.
Pull request overview
This PR updates the firmware-upgrade Xconf fetch path to derive the WAN interface name dynamically (via /nvram/wan_name.txt) instead of relying on a fixed interface, so the device MAC can be determined correctly for the Xconf request.
Changes:
- Remove the hardcoded interface-based MAC lookup macro.
- Add logic to read the WAN interface name from
/nvram/wan_name.txtand build the MAC lookup command dynamically.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
839
to
842
| chat MAC_CMD[128]={0}; | ||
| snprintf(MAC_CMD, sizeof(path), "/sbin/ifconfig %s | grep HWaddr | cut -c39-55", g_virtualIfName); | ||
| FILE *fp = popen(MAC_CMD, "r"); | ||
| if (!fp) { |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable WAN Feature requires dynamic wan details to be fetched from the respective file which contains the details