Skip to content

gh #151 Update dependency in Videoport module#163

Open
SrigayathryPugazhenthi wants to merge 2 commits into
developfrom
feature/issues151_ds_API_dependency
Open

gh #151 Update dependency in Videoport module#163
SrigayathryPugazhenthi wants to merge 2 commits into
developfrom
feature/issues151_ds_API_dependency

Conversation

@SrigayathryPugazhenthi

Copy link
Copy Markdown
Contributor

No description provided.

@SrigayathryPugazhenthi
SrigayathryPugazhenthi force-pushed the feature/issues151_ds_API_dependency branch from c47b0b6 to 94dd8c6 Compare March 3, 2026 12:04
@srinivasgtl srinivasgtl linked an issue Apr 14, 2026 that may be closed by this pull request
Comment thread include/dsVideoPort.h
* @brief Gets the HDR capabilities of the TV/display device
*
* This function is used to get the HDR capabilities of the TV/display device.
* For source devices, this function gives TV's HDR capabilities when HDMI connected.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this read from the TV EDID?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct.

Comment thread include/dsVideoPort.h Outdated
* @brief Gets the supported resolutions of TV.
*
* This function is used to get TV supported resolutions of TV/display device.
* For source devices, this function gives OR-ed value of TV supported resolutions when HDMI connected.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enhance this statement in some way like this -
"For source devices, this function returns a bitmask (OR-ed flags) of all video resolutions supported by the currently connected TV, based on its HDMI EDID. This value is updated upon HDMI hot-plug events when the EDID is re-read."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Review commands has been addressed.

@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
SrigayathryPugazhenthi
Pothiraj-Paul
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@Ulrond

Ulrond commented Jun 5, 2026

Copy link
Copy Markdown

Triage note (#163, ~320 days old, last activity ~8 days ago, BLOCKED):

This PR for #151 (Update dependency in Videoport module) is being actively worked. Note this supersedes the older #156 (just closed as stale) — same author, same issue.

Status: BLOCKED — likely awaiting review or addressing review feedback. No triage action needed beyond keeping reviewer engagement up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update dependency in Videoport module

5 participants