gh #150 Update handle to intptr_t#152
Open
hgfell683 wants to merge 1 commit into
Open
Conversation
srinivasgtl
changed the title
srinivasgtl
requested review from
AnandPandav,
Ulrond,
ddevadas53276 and
kanjoe24
June 11, 2025 15:03
Contributor
|
@AnandPandav @ddevadas53276 can you please review ? |
|
Triage note (#152, ~360 days old, last activity ~108 days ago): This PR addresses #150 (dsDisplay: Callback has incorrect variable type). The 108-day-ago activity suggests a partial revival, but it's been quiet since. Status: BEHIND main; #150 still open. Suggested next step: a quick comment confirming whether this is still being actively worked, or rebase against main to bring it back into review surface. If neither happens, this should probably be closed as abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have
typedef void (dsDisplayEventCallback_t)(int handle, dsDisplayEvent_t event,
void eventData/Optional/);
intstead of int handle it should be intptr_t handle. This disconnect is causing a compilation error when using a stricter compiler.