devpilot-test: Fix Coverity defects (1 file)#452
Open
rdkdevpilot wants to merge 1 commit into
Open
Conversation
Defect ID: b98120cd-64be-4bd6-9796-eb892770bfc3
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Coverity-reported BUFFER_SIZE defect in the RBUS table provider sample by ensuring a string copied into a fixed-size buffer is always null-terminated.
Changes:
- Adjusted
strncpylength fort2->datatoMAX_LENGTH-1. - Explicitly set
t2->data[MAX_LENGTH-1]to'\0'after copying.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
397
to
+400
| if(propertyNameEquals(name, "Data")) | ||
| { | ||
| strncpy(t2->data, rbusValue_GetString(value, NULL), MAX_LENGTH); | ||
| strncpy(t2->data, rbusValue_GetString(value, NULL), MAX_LENGTH-1); | ||
| t2->data[MAX_LENGTH-1] = '\0'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Fix for Coverity Defects
Triggered by: Sandeep Nair2
Fixed Files
sampleapps/provider/rbusTableProvider.cFix Summaries
sampleapps/provider/rbusTableProvider.cThe fix correctly addresses the BUFFER_SIZE defect in setHandler2 by reducing the strncpy count to MAX_LENGTH-1 and explicitly null-terminating t2->data[MAX_LENGTH-1]. This is a standard, correct pattern for safe string copying. The fix is minimal, targets only the flagged location, preserves all existing logic, and matches the code style used elsewhere in the file.