RDKEMW-22007:[0.2.0_8.6][RDKEMW-20113][ROGERS RTK IUV2]multiqueue Crash observed when switching between linear channels#209
Merged
Conversation
…ng between linear channels
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses a multiqueue crash seen when switching between linear channels (Rialto sink path) by hardening segment handling and improving element lifetime management, with accompanying unit-test coverage.
Changes:
- Add NULL-checks around Rialto segment sample creation/push in
SendNewSegmentEvent()to avoid dereferencing missing caps/sample. - Hold explicit references (
gst_object_ref) for audio/video/subtitle sink elements stored ingstPrivateContextto prevent dangling pointers during teardown/reconfiguration. - Extend unit-test/mocking support to validate Rialto segment push behavior (caps missing, push success, push failure).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
InterfacePlayerRDK.cpp |
Hardens Rialto segment push logic and adjusts sink ref ownership / teardown behavior to avoid crashes. |
test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp |
Adds unit tests for Rialto sink segment push paths (caps NULL, push ok/error). |
test/utests/mocks/MockGStreamer.h |
Extends GStreamer mock interface for caps/sample/push APIs used by the new logic/tests. |
test/utests/fakes/FakeGStreamer.cpp |
Routes new GStreamer APIs through the mock when present, enabling the added tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sankarimuthu
changed the title
sankarimuthu
approved these changes
Jul 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
2339
to
2342
|
|
||
| g_object_set(stream->sinkbin, "text-sink", subtitlebin, NULL); | ||
| interfacePlayerPriv->gstPrivateContext->subtitle_sink = textsink; | ||
| interfacePlayerPriv->gstPrivateContext->subtitle_sink = GST_ELEMENT(gst_object_ref(textsink)); | ||
| MW_LOG_MIL("using rialtomsesubtitlesink muted=%d sink=%p", interfacePlayerPriv->gstPrivateContext->subtitleMuted, interfacePlayerPriv->gstPrivateContext->subtitle_sink); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.