Skip to content

RDKEMW-13074: Integration of LLM team provided test cases in middleware interface player#208

Open
ALSAMEEMA wants to merge 2 commits into
developfrom
feature/RDKEMW-13074
Open

RDKEMW-13074: Integration of LLM team provided test cases in middleware interface player#208
ALSAMEEMA wants to merge 2 commits into
developfrom
feature/RDKEMW-13074

Conversation

@ALSAMEEMA

Copy link
Copy Markdown

No description provided.

…re interface player

Signed-off-by: ALSAMEEMA <alsameema4@gmail.com>
Copilot AI review requested due to automatic review settings July 20, 2026 09:58
@ALSAMEEMA
ALSAMEEMA requested a review from a team as a code owner July 20, 2026 09:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates a large set of LLM-team-provided unit tests into the middleware player interface test suite, expands coverage across several modules (Subtec, IsoBmff, externals, content security, closed captions), and adjusts test build configuration to compile and run the new/updated tests.

Changes:

  • Reworked/added extensive GoogleTest suites for Subtec PacketSender, Player externals interfaces (Thunder/RFC/ExternalsInterface/Base/Utils), ContentSecurityManager session + memory utils, and CC track info.
  • Updated multiple utest CMakeLists.txt to include new sources and adjust include paths / linked sources.
  • Minor correctness tweaks in existing IsoBmff tests (buffer header expectations and sample-count initialization).

Reviewed changes

Copilot reviewed 24 out of 37 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
test/utests/tests/SubtecTests/PacketSenderTests.cpp Replaces skipped/basic tests with a comprehensive PacketSender + runWorkerTask test suite.
test/utests/tests/SubtecTests/CMakeLists.txt Adds include dirs and new test source(s); links additional player sources needed by new tests.
test/utests/tests/PlayerIsoBmffTests/PlayerIsoBmffBufferTests.cpp Adjusts nested container buffer expectations (mvhd size bytes).
test/utests/tests/PlayerIsoBmffTests/PlayerIsoBmffBoxTests.cpp Improves Senc/Saiz truncate tests by initializing sample count in buffer and adding extra assertions.
test/utests/tests/PlayerIsoBmffTests/CMakeLists.txt Updates include directories for IsoBmff utests.
test/utests/tests/PlayerExternalsTests/PlayerThunderInterfaceTests.cpp Adds comprehensive unit tests for PlayerThunderInterface (FakeThunderAccess behavior).
test/utests/tests/PlayerExternalsTests/PlayerRFCTests.cpp Adds unit tests validating RFC disabled-mode behavior (empty string returns).
test/utests/tests/PlayerExternalsTests/PlayerExternalUtilsTests.cpp Adds tests for IsContainerEnvironment and ms_sleep.
test/utests/tests/PlayerExternalsTests/PlayerExternalsInterfaceTests.cpp Adds tests for FakePlayerExternalsInterface and PlayerExternalsInterface singleton APIs.
test/utests/tests/PlayerExternalsTests/PlayerExternalsInterfaceBaseTests.cpp Adds tests for PlayerExternalsInterfaceBase via a concrete test subclass.
test/utests/tests/PlayerExternalsTests/CMakeLists.txt Replaces old “Fun.cpp” sources with new test files and adjusts include directories.
test/utests/tests/DrmOcdmTests/CMakeLists.txt Small formatting/line-fix in test runner macro invocation.
test/utests/tests/ContentsecuritymanagerTests/PlayerMemoryUtilsTests.cpp Adds extensive tests for shared memory create/cleanup APIs and lifecycle/stress scenarios.
test/utests/tests/ContentsecuritymanagerTests/ContentSecurityManagerSessionTests.cpp Adds comprehensive tests for ContentSecurityManagerSession constructors/copy/validity/toString.
test/utests/tests/ContentsecuritymanagerTests/CMakeLists.txt Replaces older test source list with new test suites and adjusts include directories.
test/utests/tests/ClosedCaptionsTests/PlayerCCTrackInfoTests.cpp Replaces minimal CCTrackInfo test with a large enhanced suite (copy/edge/stress/thread tests).
test/utests/tests/ClosedCaptionsTests/CMakeLists.txt Minor formatting/indent adjustments in test source list.
externals/PlayerExternalsInterface.h Adds createInstance() API declaration for non-singleton instance creation.
externals/PlayerExternalsInterface.cpp Implements PlayerExternalsInterface::createInstance().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 40 to +44
#include <gtest/gtest.h>
#include <gmock/gmock.h>
#include <stdio.h>
#include <thread>
#include <chrono>
#include <memory>
Comment on lines 36 to +40
#include <gtest/gtest.h>
#include <gmock/gmock.h>
#include <stdio.h>
#include <thread>
#include <vector>
#include <algorithm>
Comment on lines +34 to +38
#include <gtest/gtest.h>
#include <iostream>
#include <cstdlib>
#include <cstring>
#include "PlayerMemoryUtils.h"
include_directories(${PLAYER_ROOT}/subtec/subtecparser)
include_directories(${PLAYER_ROOT}/playerLogManager)
include_directories(${PLAYER_ROOT}/playerJsonObject)
include_directories(${PLAYER_ROOT}/playerjsonobject)
include_directories(${PLAYER_ROOT}/subtec/subtecparser)
include_directories(${PLAYER_ROOT}/playerLogManager)
include_directories(${PLAYER_ROOT}/playerJsonObject)
include_directories(${PLAYER_ROOT}/playerjsonobject)
include_directories(${PLAYER_ROOT}/subtec/subtecparser)
include_directories(${PLAYER_ROOT}/playerLogManager)
include_directories(${PLAYER_ROOT}/playerJsonObject)
include_directories(${PLAYER_ROOT}/playerjsonobject)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants