RDKEMW-20781: Spectrum TV App lands in black screen & exits. Observing Webprocess crashed(25931591) with callstack(syscall)#192
Open
nejuma1 wants to merge 1 commit into
Open
Conversation
…g Webprocess crashed(25931591) with callstack(syscall) Reason for change: fix gstcdmidecryptor code to prevent SIGSEGV during Stop after DRM key stall Test steps: Refer ticket RDKEMW-20781 Priority: P1 Signed off by: nejumatn28@gmail.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a reported crash (SIGSEGV) in gstcdmidecryptor during Stop/teardown when DRM key acquisition stalls, by ensuring the decryptor’s key-wait path can unblock and by resetting per-session state during state transitions.
Changes:
- Replace an indefinite
g_cond_wait()for DRM key arrival with a boundedg_cond_wait_until()timeout intransform_ip. - Update teardown/state-change logic (
PAUSED->READY) to resetstreamReceivedand signal the condition variable to unblock waiting work.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
573
to
+577
| if (!cdmidecryptor->streamReceived) | ||
| g_cond_wait(&cdmidecryptor->condition, | ||
| &cdmidecryptor->mutex); | ||
| { | ||
| gint64 end_time = g_get_monotonic_time() + (10 * G_TIME_SPAN_SECOND); | ||
| if (!g_cond_wait_until(&cdmidecryptor->condition, &cdmidecryptor->mutex, end_time)) | ||
| { |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-20781: Spectrum TV App lands in black screen & exits. Observing Webprocess crashed(25931591) with callstack(syscall)
Reason for change: fix gstcdmidecryptor code to prevent SIGSEGV during Stop after DRM key stall
Test steps: Refer ticket RDKEMW-20781
Priority: P1
Signed off by: nejumatn28@gmail.com