RDKEMW-19892: [RDKEMW] [BCM Rogers Monarch IUI V2] Linear trick play (FF/RW/Seek) leads to blank screen, device hang, followed by automatic reboot. Multiple critical processes (gmem, WPENetworkProce, WorkerPoolType: etc.) crash were observed.

[ALSAMEEMA]

No description provided.

[Copilot]

Pull request overview

This PR addresses a Widevine multi-key regression where cenc:default_KID (UUID string form from DASH manifests) was not being matched against 16-byte binary Key IDs parsed from PSSH, leading to wrong-key selection during trick play and downstream failures.

Changes:

• Update WidevineDrmHelper::setDefaultKeyID() to also accept UUID strings (hyphenated / case variants) by decoding them to 16-byte binary before matching.
• Add/adjust fallback + logging behavior in WidevineDrmHelper::getKey()/setDefaultKeyID().
• Add a new unit-test suite covering default key selection scenarios, including multi-key selection via UUID.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
drm/helper/WidevineDrmHelper.cpp	Implements UUID-to-binary matching for setDefaultKeyID() and adjusts fallback/logging in key selection.
test/utests/tests/DrmTests/DrmHelperTests.cpp	Adds unit tests intended to validate correct default key selection across multiple input formats and key counts.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (6)

test/utests/tests/DrmTests/DrmHelperTests.cpp:623

• psshDataPtr is freed only at the end of the test, but ASSERT_TRUE(parsePssh(...)) will abort the test early on failure and skip the free(), leaking the decode buffer. Free the buffer before asserting by storing the parse result in a local bool (and nulling the pointer so the existing cleanup stays safe).

	std::shared_ptr<DrmHelper> widevineHelper = DrmHelperEngine::getInstance().createHelper(drmInfo);
	ASSERT_NE(widevineHelper, nullptr);
	ASSERT_TRUE(widevineHelper->parsePssh(psshDataPtr, (uint32_t)psshDataLen));

test/utests/tests/DrmTests/DrmHelperTests.cpp:656

• psshDataPtr is freed only at the end of the test, but ASSERT_TRUE(parsePssh(...)) will abort early on failure and skip the free(). Free the decode buffer before asserting to keep this test leak-free even when it fails.

	std::shared_ptr<DrmHelper> widevineHelper = DrmHelperEngine::getInstance().createHelper(drmInfo);
	ASSERT_NE(widevineHelper, nullptr);
	ASSERT_TRUE(widevineHelper->parsePssh(psshDataPtr, (uint32_t)psshDataLen));

test/utests/tests/DrmTests/DrmHelperTests.cpp:709

• ASSERT_TRUE(parsePssh(...)) can abort the test before the trailing free(psshDataPtr) runs, leaking the base64 decode buffer when the assertion fails. Prefer freeing immediately after parsing (and null the pointer so the existing cleanup remains safe).

	std::shared_ptr<DrmHelper> widevineHelper = DrmHelperEngine::getInstance().createHelper(drmInfo);
	ASSERT_NE(widevineHelper, nullptr);
	ASSERT_TRUE(widevineHelper->parsePssh(psshDataPtr, (uint32_t)psshDataLen));

test/utests/tests/DrmTests/DrmHelperTests.cpp:772

• This test frees psshDataPtr at the end, but ASSERT_TRUE(parsePssh(...)) will return early on failure and skip cleanup. Free the decode buffer before the assertion to avoid leaks in failing runs.

	std::shared_ptr<DrmHelper> widevineHelper = DrmHelperEngine::getInstance().createHelper(drmInfo);
	ASSERT_NE(widevineHelper, nullptr);
	ASSERT_TRUE(widevineHelper->parsePssh(psshDataPtr, (uint32_t)psshDataLen));

test/utests/tests/DrmTests/DrmHelperTests.cpp:823

• psshDataPtr cleanup can be skipped if ASSERT_TRUE(parsePssh(...)) fails (ASSERT aborts the test). Free the buffer before asserting so this test stays clean under failure/sanitizers.

	std::shared_ptr<DrmHelper> widevineHelper = DrmHelperEngine::getInstance().createHelper(drmInfo);
	ASSERT_NE(widevineHelper, nullptr);
	ASSERT_TRUE(widevineHelper->parsePssh(psshDataPtr, (uint32_t)psshDataLen));

test/utests/tests/DrmTests/DrmHelperTests.cpp:865

• As written, ASSERT_TRUE(parsePssh(...)) can abort the test before the final free(psshDataPtr) executes, leaking the decode buffer on failure. Free psshDataPtr immediately after parsing and assert on the saved result.

	std::shared_ptr<DrmHelper> widevineHelper = DrmHelperEngine::getInstance().createHelper(drmInfo);
	ASSERT_NE(widevineHelper, nullptr);
	ASSERT_TRUE(widevineHelper->parsePssh(psshDataPtr, (uint32_t)psshDataLen));