REFPLTV-3174: wpeframework crash happens when rebooted the device without HDMI.#375
Open
smuthu065 wants to merge 1 commit into
Open
REFPLTV-3174: wpeframework crash happens when rebooted the device without HDMI.#375smuthu065 wants to merge 1 commit into
smuthu065 wants to merge 1 commit into
Conversation
…hout HDMI. Reason for change: WpeFramework Crash issue fix on Westeros-soc-drm component. Test Procedure: Build and verify. Risks: High. Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Yocto westeros-soc-drm recipe to apply an additional downstream patch intended to prevent a WpeFramework crash when rebooting a device without HDMI, by adjusting DRM encoder/CRTC selection logic in westeros-gl.c.
Changes:
- Add a new patch to
westeros-soc-drm.bbto address the “No HDMI” crash scenario. - Introduce
wstFindEncoderForCrtc()and refactor encoder selection inwstInitCtx()/wstUpdateCtx().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| recipes-graphics/westeros-soc/westeros-soc-drm.bb | Adds the new patch to SRC_URI so it is applied during the build. |
| recipes-graphics/westeros-soc/files/0001-REFPLTV-3174-NoHDMI-WpeFramework-crash-issue-fix.patch | Refactors DRM encoder selection and adds logging to mitigate encoder/CRTC mismatches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+67
| uint32_t crtcId= 0; | ||
| bool found= false; | ||
| ctx->enc= drmModeGetEncoder(ctx->drmFd, res->encoders[i]); |
Comment on lines
+35
to
+40
| + if ( encoder ) | ||
| + { | ||
| + if ( encoder->possible_crtcs & (1 << crtcIndex) ) | ||
| + { | ||
| + encoder->crtc_id= crtcId; | ||
| + break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: WpeFramework Crash issue fix on Westeros-soc-drm component.
Test Procedure: Build and verify.
Risks: High.
Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com