Skip to content

Rebase to develop#211

Open
Sonajeya31 wants to merge 440 commits into
rdkemw-1993-bothfrom
develop
Open

Rebase to develop#211
Sonajeya31 wants to merge 440 commits into
rdkemw-1993-bothfrom
develop

Conversation

@Sonajeya31

Copy link
Copy Markdown
Contributor

No description provided.

@Sonajeya31
Sonajeya31 requested review from a team as code owners August 11, 2025 09:12
@CLAassistant

CLAassistant commented Aug 11, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented Dec 11, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copilot AI review requested due to automatic review settings January 12, 2026 19:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR rebases changes to the develop branch, integrating multiple middleware component updates, new recipes, configuration changes, and infrastructure improvements across the RDK ecosystem.

Changes:

  • Updated versions and SRCREVs for numerous middleware components (rbus, telemetry, bluetooth, dobby, systimemgr, rfc, etc.)
  • Added new recipes for components like aker, paroduscl, network-hotplug, mustach, littlesheens, irtt, cpeabs, and others
  • Introduced configuration changes for RDKB stack integration, systemd preferences, and layer dependencies
  • Added GitHub workflow files for CLA, FOSSID scanning, and automated PR creation

Reviewed changes

Copilot reviewed 93 out of 93 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
setup-environment Enhanced to support both openembedded-core and poky directory structures, added kirkstone distro support
rename_srcrev.sh Removed several XRE-related SRCREV replacement lines
Multiple .bb recipe files Added new recipes for various RDK components with version control and dependencies
conf/distro/ files Updated RDKB and RDKV configurations, systemd preferences, security flags
GitHub workflows Added automation for CLA, FOSSID scanning, and PR validation
CHANGELOG.md Comprehensive changelog covering releases 1.4.0 through 1.14.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -28,6 +28,7 @@
#include <glib-unix.h>
#include <libmanette/libmanette.h>
#include <linux/input.h>

Copilot AI Jan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backtick character at the end of this include statement appears to be a typo. It should be removed as it will likely cause a compilation error.

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,51 @@
SUMMARY = "This receipe compiles and builds aker."

Copilot AI Jan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error in SUMMARY field. The word "receipe" should be "recipe".

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,24 @@
SUMMARY = "mustach"
DESCRIPTION = "A C library implementation of the mustache templating languge"

Copilot AI Jan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error in DESCRIPTION field. The word "languge" should be "language".

Copilot uses AI. Check for mistakes.
@@ -0,0 +1 @@
SUBSYSTEM=="net", KERNEL!="lo", ENV{SYSTEMD_WANTS}+="network@$name.service" ENV{SYSTEMD_ALIAS}="/$name"

Copilot AI Jan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma between environment variables. The ENV{SYSTEMD_WANTS} assignment should be separated from ENV{SYSTEMD_ALIAS} with a comma.

Copilot uses AI. Check for mistakes.
Comment on lines +15 to +17
SRC_URI = "git://github.com/Comcast/littlesheens.git;protocol=https;branch=master"
SRCREV = "${AUTOREV}"
PV := "${PV}+${SRCPV}"

Copilot AI Jan 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The littlesheens recipe fetches build code from git://github.com/Comcast/littlesheens.git;branch=master with SRCREV = "${AUTOREV}", meaning every build pulls whatever is at the current branch head instead of an immutable commit. This creates a supply-chain risk where a compromised or hijacked upstream repository (or DNS/route to it) could inject malicious code that will be built and run with your build-time and device privileges. Pin this dependency to a specific trusted commit SHA or release tag (and avoid AUTOREV for production builds) so that only audited code is fetched and built.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 16, 2026 01:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 93 out of 93 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +16 to 21
CFLAGS:append:broadband += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}"

S = "${WORKDIR}/git"
CFLAGS:append += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}"
inherit pkgconfig cmake
EXTRA_OECMAKE += "-DRDK_LOGGER=ON -DBUILD_TESTING=OFF -DBUILD_YOCTO=true"
EXTRA_OECMAKE:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', ' -DFEATURE_SUPPORT_ONBOARD_LOGGING=true',d)}"

Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name has inconsistent spelling throughout the file. Lines 16-18 use "CFLAGS:append" for broadband, but line 28 uses "CFLAGS:append" without the broadband suffix, creating potential override conflicts. Additionally, line 21 removes an EXTRA_OECMAKE line that may still be needed for non-broadband builds.

Copilot uses AI. Check for mistakes.
Comment thread setup-environment
fi

OE_CORE_LAYER="openembedded-core"
if [ -d "poky" ];then

Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after semicolon in the if statement condition. For shell scripts, it's best practice to include a space after the semicolon for readability.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to +35
SYSTEMD_AUTO_ENABLE:${PN} = "enable"
SYSTEMD_SERVICE:${PN} = " dsm.service "

Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYSTEMD_SERVICE configuration has duplicate entries. Line 34 sets "SYSTEMD_AUTO_ENABLE:${PN} = enable" and line 35 sets "SYSTEMD_SERVICE:${PN} = dsm.service", which are then duplicated on lines 24-25. The duplicate lines 34-35 should be removed.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 20, 2026 14:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 93 out of 93 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,96 @@
Date: Fri, Aug 30 20:30:21 2024 +0000

Copilot AI Jan 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date "Fri, Aug 30 20:30:21 2024" is in the past but the patch context suggests this is part of a future merge (2025). Please verify the date is correct or update it to reflect the actual date of the change.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 27, 2026 13:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings January 28, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 93 out of 93 changed files in this pull request and generated 30 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +16 to 20
CFLAGS:append:broadband += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}"

S = "${WORKDIR}/git"
CFLAGS:append += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}"
inherit pkgconfig cmake
EXTRA_OECMAKE += "-DRDK_LOGGER=ON -DBUILD_TESTING=OFF -DBUILD_YOCTO=true"

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cimplog recipe has moved the CFLAGS:append line from after the 'S =' assignment to before it. While this should work, the EXTRA_OECMAKE line that was after the moved CFLAGS has been removed. The removed line was 'EXTRA_OECMAKE:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', ' -DFEATURE_SUPPORT_ONBOARD_LOGGING=true',d)}"'. Verify that this CMake flag is no longer needed or is set elsewhere, as removing it could disable onboard logging support.

Copilot uses AI. Check for mistakes.
Comment on lines +71 to +77
sed -z 's/"name": "gwfailover",\n[[:blank:]]*"bitposition": 1,\n[[:blank:]]*"support": true,/"name": "gwfailover",\n"bitposition": 1,\n"support": false,/g' ${WORKDIR}/webconfig_broadband_metadata.json > ${WORKDIR}/out.txt
mv ${WORKDIR}/out.txt ${WORKDIR}/webconfig_broadband_metadata.json
fi
install -d ${D}/usr/ccsp/webconfig
install -d ${D}/etc
touch ${D}/etc/WEBCONFIG_ENABLE
(${PYTHON} ${WORKDIR}/metadata_parser.py ${WORKDIR}/webconfig_metadata.json ${D}/etc/webconfig.properties ${MACHINE})
(${PYTHON} ${WORKDIR}/metadata_parser.py ${WORKDIR}/webconfig_broadband_metadata.json ${D}/etc/webconfig.properties ${MACHINE})

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 71 and 72 both reference the same file 'webconfig_metadata.json' but line 71 changes it to 'webconfig_broadband_metadata.json' while line 77 also makes the same change. However, the original lines show different patterns - one has the filename used in sed command and the other in the metadata_parser.py invocation. Verify that both occurrences should use 'webconfig_broadband_metadata.json' and that this file exists, as this could cause build or runtime failures if the file is missing.

Copilot uses AI. Check for mistakes.
Comment thread conf/layer.conf
# add BBMASK .= "!<pattern>"
# in your layer
BBMASK =. "recipes-gnome/gnome-settings-daemon"
BBMASK .= "|.meta-rdk-oss-reference/recipes-rdk/breakpad_wrapper/breakpad-wrapper.bb"

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 25 adds a BBMASK pattern to mask out the breakpad-wrapper recipe from meta-rdk-oss-reference. This means if that layer has a breakpad-wrapper.bb file, it will be ignored. However, this PR also adds a recipes-common/breakpad_wrapper/breakpad-wrapper.bb file. Verify that there's no conflict and that the correct version of breakpad-wrapper is being used.

Copilot uses AI. Check for mistakes.
ExecStartPre=/bin/sh -c '/bin/mkdir -p ${DUMPSDIR_TEMP}; /bin/chmod -R 777 ${DUMPSDIR_TEMP}'
ExecStartPre=/usr/bin/find ${DUMPSDIR_TEMP} -mindepth 1 -exec rm {} \;
ExecStart=/usr/bin/memcr -d "${DUMPSDIR_PERSIST};${DUMPSDIR_TEMP}" -N -l ${LOCATOR} -f -z -e -t ${TIMEOUT}
ExecStart=/usr/bin/memcr -d "${DUMPSDIR_PERSIST};${DUMPSDIR_TEMP}" -N -l ${LOCATOR} -c -f -z -e -t ${TIMEOUT}

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '-c' flag is added to the memcr ExecStart command without explanation. According to the context, this enables checksum functionality. Enabling checksums will add CPU overhead and may impact performance. This change should be documented and verified that systems can handle the additional processing requirements.

Copilot uses AI. Check for mistakes.
Comment thread conf/distro/rdk.conf
DISTRO_FEATURES_RDK ?= "rdk-dlna"

DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_LIBC} ${DISTRO_FEATURES_RDK}"
DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_RDK}"

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 67 in rdk.conf removes '${DISTRO_FEATURES_LIBC}' from the DISTRO_FEATURES definition. This variable typically includes libc-specific features. Removing it could cause issues with recipes that depend on specific libc features being declared in DISTRO_FEATURES. Verify that this removal is intentional and won't break libc-dependent functionality.

Suggested change
DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_RDK}"
DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_LIBC} ${DISTRO_FEATURES_RDK}"

Copilot uses AI. Check for mistakes.
inherit pkgconfig autotools systemd ${@bb.utils.contains("DISTRO_FEATURES", "kirkstone", "python3native", "pythonnative", d)} breakpad-logmapper

CFLAGS += " -DDROP_ROOT_PRIV "
CFLAGS += " -DDROP_ROOT_PRIV -DENABLE_MTLS "

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 30 changes CFLAGS from adding '-DDROP_ROOT_PRIV' to adding '-DDROP_ROOT_PRIV -DENABLE_MTLS'. Adding ENABLE_MTLS flag enables mutual TLS authentication. Verify that the code supports this flag and that enabling MTLS by default won't break existing configurations that don't have MTLS certificates configured.

Copilot uses AI. Check for mistakes.
Comment on lines +22 to +28
DEPENDS:append:broadband += " rbus"
export rbus_CFLAGS = "-I$(PKG_CONFIG_SYSROOT_DIR)${includedir}/rbus"
export rbus_LIBS = "-lrbus"

EXTRA_OEMAKE += "-e MAKEFLAGS="
EXTRA_OECONF:append = " --enable-iarmbus=yes --enable-tr69hostif=yes"
EXTRA_OECONF:append:client = " --enable-iarmbus=yes --enable-tr69hostif=yes"
EXTRA_OECONF:append:broadband = " --enable-rdkb=yes --enable-tr181set=yes"

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 28 adds 'DEPENDS:append:broadband += " rbus"' which changes rbus from being included conditionally to being a hard dependency for broadband builds. Line 27 previously had EXTRA_OECONF only for :client. Verify that broadband builds can satisfy the rbus dependency and that this doesn't break builds.

Copilot uses AI. Check for mistakes.
SRCREV_ecfsgeneric= "822d726d14e575ec9c73198ce939733abd0d365b"
SRCREV:pn-remotedebugger = "300d29e105f6a7244bff81fa0357dac914dd8913"
SRCREV_sshkeys = "3a1c7d6a07586117bd992fe72ae3365fdd7ef2f3"
SRCREV_mount-utils = "c1aeb29c8e1f236babdd6a1a4538c5b451c7b8c1"

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rdkb.inc file adds many new BBMASKs (lines 159-177) and introduces a new MIDDLEWARE_ARCH override (line 186). More importantly, it adds numerous SRCREV overrides for specific packages (lines 195-213). Setting SRCREV for multiple packages to specific values could cause issues if these packages need to be updated independently. This centralized version pinning should be carefully managed to avoid blocking necessary updates.

Suggested change
SRCREV_mount-utils = "c1aeb29c8e1f236babdd6a1a4538c5b451c7b8c1"
SRCREV:pn-mount-utils ?= "c1aeb29c8e1f236babdd6a1a4538c5b451c7b8c1"

Copilot uses AI. Check for mistakes.
@@ -28,6 +28,7 @@
#include <glib-unix.h>
#include <libmanette/libmanette.h>
#include <linux/input.h>

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after #include directive. Line 18 shows '#include <dlfcn.h>`' with a backtick at the end instead of proper quote/angle bracket. This should be '#include <dlfcn.h>' without the backtick.

Copilot uses AI. Check for mistakes.
Comment on lines +19 to +20
DEPENDS = "cjson rdk-logger trower-base64 msgpack-c webconfig-framework rbus libsyswrapper"
DEPENDS:append:client = " iarmbus iarmmgrs"

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DEPENDS line removes 'iarmbus iarmmgrs' for all configurations and only adds them back for ':client' override. This could break builds that previously had these dependencies. Verify that all non-client configurations don't need these dependencies, or if this is a breaking change that needs to be documented.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 30, 2026 21:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

ks734 and others added 4 commits February 2, 2026 15:57
Reason for change:  Upgrade RBUS to 2.11.0 which has Coverity Fixes for rtMessage/rbus
Test Procedure: Tested and verified
Priority: P1
Risks: Medium
Copilot AI review requested due to automatic review settings February 4, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 93 out of 93 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread setup-environment

# Clean PATH of any previous oe-core bitbake or scripts directories
export PATH="$(echo $PATH | sed 's!/[^:]\+/openembedded-core/\(bitbake/bin\|scripts\):!!g')"
export PATH="$(echo $PATH | sed 's!/[^:]\+/$OE_CORE_LAYER/\(bitbake/bin\|scripts\):!!g')"

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable OE_CORE_LAYER is used inside single quotes in the sed pattern, which prevents variable expansion. The sed pattern 's!/[^:]+/$OE_CORE_LAYER/(bitbake/bin|scripts):!!g' will look for the literal string "$OE_CORE_LAYER" instead of its value. This should use double quotes or the variable should be concatenated outside the sed pattern to allow proper variable expansion.

Copilot uses AI. Check for mistakes.
#include <glib-unix.h>
#include <libmanette/libmanette.h>
#include <linux/input.h>
+#include <dlfcn.h>`

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra backtick () at the end of the line "#include <dlfcn.h>". This appears to be a formatting error in the patch file. While patch files often have their own formatting, this trailing backtick looks like a mistake from copying or formatting the diff.

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,24 @@
SUMMARY = "mustach"
DESCRIPTION = "A C library implementation of the mustache templating languge"

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "languge" should be "language".

Copilot uses AI. Check for mistakes.
@@ -0,0 +1 @@
SUBSYSTEM=="net", KERNEL!="lo", ENV{SYSTEMD_WANTS}+="network@$name.service" ENV{SYSTEMD_ALIAS}="/$name"

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma between ENV{SYSTEMD_WANTS} and ENV{SYSTEMD_ALIAS}. In udev rules syntax, multiple assignments should be separated by commas. This line should have a comma after the closing quote of "network@$name.service".

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,51 @@
SUMMARY = "This receipe compiles and builds aker."

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "receipe" should be "recipe".

Copilot uses AI. Check for mistakes.


# Add any extra packaging if needed
FILES_${PN} += "${bindir}/logupload"

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable syntax FILES_${PN} is deprecated in newer Yocto versions. It should be updated to use the modern syntax FILES:${PN} with a colon instead of an underscore. This is consistent with other variable overrides shown elsewhere in the recipe (e.g., CFLAGS:append, LDFLAGS:append on nearby lines).

Suggested change
FILES_${PN} += "${bindir}/logupload"
FILES:${PN} += "${bindir}/logupload"

Copilot uses AI. Check for mistakes.
maniselva006c and others added 2 commits February 4, 2026 13:26
Reason for change:
The clang compiler is required for the secclient-rs module. This commit integrates the meta-clang recipe, which provides compiler version 1.72.0.

Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
h1712 and others added 21 commits June 25, 2026 19:00
RDKEMW-19967: Update rdk.conf for OSS 4.13 Changes
* RDKEMW-18000:Enriching RootFS Manifest with source uri

* RDKEMW-18000:Enriching RootFS Manifest with source uri

* Update rdk.conf

* Update embed-source-metadata.inc‎

* Rename embed-source-metadata.inc‎ to embed-source-metadata.inc

* Update rdk.conf

* Update embed-source-metadata.inc

* Update rdk.conf

---------

Co-authored-by: nanimatta <84963246+nanimatta@users.noreply.github.com>
RDKEMW-20296: Enabling Multiapp rdm packages download
RDKEMW-17665: Add swap memory reporting and enhanced container metrics

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 102 out of 102 changed files in this pull request and generated 6 comments.


EXTRA_OEMAKE += "LIBS='-lsafec'"

DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
Comment on lines +29 to +32
do_install () {
install -d ${D}${bindir}
install -m 4755 ${B}/MemCapture ${D}${bindir}
}
@@ -0,0 +1,38 @@
SUMMARY = "Process Moniter utility and runner service"
##########################################################################

[Unit]
Description=Process Moniter
install -d ${D}${base_libdir}/rdk

#config File
rm -rf ${D}${sysconfdir}/chrony.conf


# service to start chrony
rm -rf ${D}${systemd_unitdir}/system/chronyd.service
Saranya2421 and others added 3 commits July 3, 2026 10:53
Co-authored-by: Saranya <saranya_elango@comcast.com>
RDKEMW-20764 : Changes to support Hash Equivalence

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 99 out of 99 changed files in this pull request and generated 11 comments.

Comment thread setup-environment

# Clean PATH of any previous oe-core bitbake or scripts directories
export PATH="$(echo $PATH | sed 's!/[^:]\+/openembedded-core/\(bitbake/bin\|scripts\):!!g')"
export PATH="$(echo $PATH | sed 's!/[^:]\+/$OE_CORE_LAYER/\(bitbake/bin\|scripts\):!!g')"

EXTRA_OEMAKE += "LIBS='-lsafec'"

DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
# or enable this distro feature
CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'debug_curl_cdl', ' -DCURL_DEBUG', '', d)}"

DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e"

SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
SYSTEMD_SERVICE:${PN} += "dcmd.service"
inherit breakpad-wrapper
DEPENDS += "breakpad breakpad-wrapper"
BREAKPAD_BIN:append = "logupload"
@@ -0,0 +1,2 @@
# Disable USB to Ethernet interface
KERNEL!="lo", ACTION=="add", SUBSYSTEM=="net", SUBSYSTEMS=="usb", ENV{ID_BUS}=="usb", ATTRS{authorized}=="1", PROGRAM="/lib/rdk/disableUSBEthernet.sh", RESULT=="TRUE", ENV{SYSTEMD_WANTS}="", ENV{SYSTEMD_ALIAS}="", RUN+="/bin/sh -c 'echo 0 >/sys/bus/usb/devices/$id/authorized'"
Comment on lines +5 to +9
SRC_URI = " \
file://network@.service \
file://network.rules \
file://lan-iface@.service \
"
Comment on lines +20 to +23
fi
install -d ${D}${sysconfdir}/udev/rules.d
install -m 0644 ${WORKDIR}/network.rules ${D}${sysconfdir}/udev/rules.d/network.rules
}
Comment on lines +29 to +32
do_install () {
install -d ${D}${bindir}
install -m 4755 ${B}/MemCapture ${D}${bindir}
}
[Service]
Type=oneshot
RemainAfterExit=yes
ExecStart=/etc/ble_adv_onboard_hci.sh
svc_rdkgerrit02 and others added 3 commits July 13, 2026 19:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 100 out of 100 changed files in this pull request and generated 9 comments.

Comment thread setup-environment
Comment on lines 60 to 62
# Clean PATH of any previous oe-core bitbake or scripts directories
export PATH="$(echo $PATH | sed 's!/[^:]\+/openembedded-core/\(bitbake/bin\|scripts\):!!g')"
export PATH="$(echo $PATH | sed 's!/[^:]\+/$OE_CORE_LAYER/\(bitbake/bin\|scripts\):!!g')"

Comment on lines +18 to +21
#include <linux/input.h>
+#include <dlfcn.h>`

struct GamepadProxy;
Comment on lines +1 to +2
#Disable USB KeyBoard and Mouse based on RFC parameter
ACTION=="add", SUBSYSTEM=="input", SUBSYSTEMS=="usb", ENV{ID_BUS}=="usb", ATTRS{authorized}=="1", TAG+="systemd", ENV{SYSTEMD_WANTS}+="usb-input@$id.service"
Comment on lines +1 to +2
# Disable USB to Ethernet interface
KERNEL!="lo", ACTION=="add", SUBSYSTEM=="net", SUBSYSTEMS=="usb", ENV{ID_BUS}=="usb", ATTRS{authorized}=="1", PROGRAM="/lib/rdk/disableUSBEthernet.sh", RESULT=="TRUE", ENV{SYSTEMD_WANTS}="", ENV{SYSTEMD_ALIAS}="", RUN+="/bin/sh -c 'echo 0 >/sys/bus/usb/devices/$id/authorized'"
Comment on lines +5 to +25
SRC_URI = " \
file://network@.service \
file://network.rules \
file://lan-iface@.service \
"

FILES:${PN} = "${sysconfdir}/udev/rules.d/* ${systemd_unitdir}/system/*"

RDEPENDS:${PN} = "udev"

do_install() {
install -d ${D}${systemd_unitdir}/system

if ${@bb.utils.contains('DISTRO_FEATURES', 'benchmark_enable', 'false', 'true', d)}; then
install -m 0644 ${WORKDIR}/*.service ${D}${systemd_unitdir}/system
fi
install -d ${D}${sysconfdir}/udev/rules.d
install -m 0644 ${WORKDIR}/network.rules ${D}${sysconfdir}/udev/rules.d/network.rules
}

inherit systemd
Comment on lines +11 to +12
[Install]
Alias=multi-user.target.wants/lan-iface@%i.service
Comment on lines +22 to +34
"CurrentRunLevel": 5,
"id": 2,
"packager": "local-tarball"
},
{
"name": "user",
"enabled": true,
"status": "Up",
"InitialRunLevel": 5,
"CurrentRunLevel": 5,
"id": 2,
"packager": "local-tarball"
}
Comment on lines +29 to +32
do_install () {
install -d ${D}${bindir}
install -m 4755 ${B}/MemCapture ${D}${bindir}
}
Comment on lines +5 to 10
PV = "1.0.0"
PR = "r0"
PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"

PKG_VERSION = "0.5.15"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.