RDKEMW-19013: Disable LEDControl for RealTime Devices and Enable for vDevice#3055
Open
yuvaramachandran-gurusamy wants to merge 2 commits into
Open
RDKEMW-19013: Disable LEDControl for RealTime Devices and Enable for vDevice#3055yuvaramachandran-gurusamy wants to merge 2 commits into
yuvaramachandran-gurusamy wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves entservices-ledcontrol out of the generic middleware packagegroup and into the vDevice XFCE-specific packagegroup, aligning LEDControl installation with the intended target images (disabled for RealTime device images, enabled for vDevice XFCE image builds).
Changes:
- Removed
entservices-ledcontrolfrompackagegroup-middleware-layer.bb. - Added
entservices-ledcontroltopackagegroup-middleware-layer-core-xfce.bb(vDevice XFCE packagegroup).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Drops entservices-ledcontrol from the generic middleware packagegroup dependency list. |
| recipes-core/packagegroups/packagegroup-middleware-layer-core-xfce.bb | Adds entservices-ledcontrol to the vDevice XFCE packagegroup so vDevice images pull it in. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
24
to
28
| telemetry \ | ||
| wpeframework \ | ||
| wpeframework-clientlibraries \ | ||
| entservices-ledcontrol \ | ||
| " |
Comment on lines
76
to
82
| entservices-runtime \ | ||
| entservices-maintenancemanager \ | ||
| entservices-firmwaredownload \ | ||
| entservices-firmwareupdate \ | ||
| entservices-ledcontrol \ | ||
| entservices-frontpanel \ | ||
| entservices-remotecontrol \ | ||
| entservices-voicecontrol \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-19013: Disable LEDControl for RealTime Devices and Enable for vDevice
Signed-off-by: yuvaramachandran_gurusamy [yuvaramachandran_gurusamy@comcast.com]