RDKMVE-2589: Move RCU Keymap configuration to vendor layer#109
Open
Nairisnotavailable wants to merge 2 commits into
Open
RDKMVE-2589: Move RCU Keymap configuration to vendor layer#109Nairisnotavailable wants to merge 2 commits into
Nairisnotavailable wants to merge 2 commits into
Conversation
Reason for change: Move RCU Keymap configuration to vendor layer Test Procedure : Build is successful Priority : Unprioritized Risks : None
Reason for change: Move RCU Keymap configuration to vendor layer Test Procedure : Build is successful Priority : Unprioritized Risks : None
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the reference RCU keymap configuration from this layer so it can be provided by a vendor layer instead, reducing generic/community-layer coupling to a specific remote/keymap setup.
Changes:
- Deletes the generic window manager RCU keymap JSON (
conf/generic_rcu_keymapping.json). - Removes the
rdkv_install_keymapROOTFS postprocess hook that installed the keymap and injectedRDK_WINDOW_MANAGER_KEYMAP_FILEintowpeframework.service.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
conf/generic_rcu_keymapping.json |
Removes the generic reference keymap payload from this layer. |
classes/rdkv-community-configs.bbclass |
Drops the postprocess logic that installed the keymap and propagated the env var into the systemd unit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arun-madhavan-013
approved these changes
Jul 1, 2026
arun-madhavan-013
left a comment
arun-madhavan-013
left a comment
Contributor
There was a problem hiding this comment.
Please make sure to have the vendor changes available before this gets merged
Contributor
|
Require(s): rdkcentral/meta-vendor-raspberrypi-dev#372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Move RCU Keymap configuration to vendor layer
Test Procedure : Build is successful
Priority : Unprioritized
Risks : None