XER10-2389 : Gateway LED lite solid white in WFO mode while using XLE as backup mode#3
Open
michaelamal wants to merge 3 commits into
Open
XER10-2389 : Gateway LED lite solid white in WFO mode while using XLE as backup mode#3michaelamal wants to merge 3 commits into
michaelamal wants to merge 3 commits into
Conversation
Reason for change: test Test Procedure: Build and verify Risks: Low Priorty: P1
Reason for change: test Test Procedure: Build and verify Risks: Low Priorty: P1
… as backup mode Reason for change: LEDmanager WFO Test Procedure: build procedure any password. Risks:NA Priority:P1 Signed-off-by: Michael_AmalAnand@comcast.com
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
biju-vi
reviewed
Jun 10, 2026
| FILE *fp; | ||
| char buffer[512]; | ||
| CcspTraceError((" is_remote_lte_up called \n")); | ||
| fp = popen("dmcli eRT getv Device.X_RDK_WanManager.InterfaceActiveStatus", "r"); |
biju-vi
requested changes
Jun 10, 2026
| while (fgets(buffer, sizeof(buffer), fp)) { | ||
| if (strstr(buffer, "REMOTE_LTE,1")) { | ||
| pclose(fp); | ||
| CcspTraceError((" is_remote_lte_up returned true \n")); |
| } | ||
|
|
||
| pclose(fp); | ||
| CcspTraceError((" is_remote_lte_up returned false \n")); |
| strncpy(wan_event, led_wan_events[i].wan_event, BUFLEN_64-1); | ||
| if(strcmp(led_wan_events[i].wan_event,"rdkb_ipv4_only") == 0) | ||
| { | ||
| CcspTraceError((" wan_event is rdkb_ipv4_only \n")); |
| return i; | ||
| } | ||
|
|
||
| bool is_remote_lte_up() { |
There was a problem hiding this comment.
LED manager is a generic code . Try to use HAL LED configuration file for interface specific LED settings
biju-vi
reviewed
Jun 10, 2026
| return i; | ||
| } | ||
|
|
||
| bool is_remote_lte_up() { |
There was a problem hiding this comment.
wan interface state change should be detected by respective component and set a sysevent for wan. From LED manager point of view, it should be just a "wan sysevent" irrespective of primary/backup interfaces. So check which component is subscribing for Device.X_RDK_WanManager.InterfaceActiveStatus. That component should check LTE status and set wan event
biju-vi
requested changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: apparmor DNIED error
Test Procedure: build procedure
any password.
Risks:NA
Priority:P1
Signed-off-by: Michael_AmalAnand@comcast.com