Skip to content

RDKB-66032 : Add explicit permissions block to PR Format Check workflow#62

Merged
bunnam988 merged 4 commits into
developfrom
fix/pr-format-check-permissions
Jul 15, 2026
Merged

RDKB-66032 : Add explicit permissions block to PR Format Check workflow#62
bunnam988 merged 4 commits into
developfrom
fix/pr-format-check-permissions

Conversation

@bunnam988

Copy link
Copy Markdown
Contributor

Summary

Adds an explicit least-privilege permissions block to the PR Format Check caller workflow, resolving the CodeQL warning actions/missing-workflow-permissions.

permissions:
  contents: read
  pull-requests: write

Without this, the workflow inherits the repo/org default token permissions (potentially read-write). This restricts it to the minimum required.

Files changed

  • .github/workflows/pr-lint.yml

Copilot AI review requested due to automatic review settings July 13, 2026 09:16
@bunnam988 bunnam988 requested review from a team as code owners July 13, 2026 09:16
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

📋 PR Format Reminder

  • Description missing:
    • Reason for change
    • Test Procedure
    • Risks (Low / Medium / High)
    • Priority (P0 / P1 / P2)

Expected:

TICKET-123 : brief description

Reason for change: why
Test Procedure: how to verify
Risks: Low / Medium / High
Priority: P0 / P1 / P2

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the GitHub Actions token scope for the “PR Format Check” workflow by adding an explicit least-privilege permissions block, addressing the CodeQL warning about missing workflow permissions and preventing inheritance of broader default permissions.

Changes:

  • Added an explicit workflow-level permissions block (contents: read, pull-requests: write) for the PR Format Check workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 13, 2026 10:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/pr-lint.yml
Copilot AI review requested due to automatic review settings July 13, 2026 10:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/pr-lint.yml
Comment thread .github/workflows/pr-lint.yml
@bunnam988 bunnam988 changed the title Add explicit permissions block to PR Format Check workflow Add explicit permissions block to PR Format Check workflow. Jul 13, 2026
Copilot AI review requested due to automatic review settings July 13, 2026 11:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/pr-lint.yml
Comment thread .github/workflows/pr-lint.yml
@bunnam988 bunnam988 changed the title Add explicit permissions block to PR Format Check workflow. RDKB-66032 : Add explicit permissions block to PR Format Check workflow Jul 13, 2026
@bunnam988 bunnam988 merged commit 5f30d4a into develop Jul 15, 2026
11 of 12 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants