Skip to content

RDKEMW-6331 : Fix HdmiCecSink COM-RPC issues #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smanes0213 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-6331 : Fix HdmiCecSink COM-RPC issues #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3489019
RDKEMW-6331 : Fix HdmiCecSink COM-RPC issues
smanes0213 Jul 31, 2025
e52e338
Merge branch 'develop' into feature/RDKEMW-6331
smanes0213 Aug 5, 2025
adadeee
Update MessageDecoder.cpp
smanes0213 Aug 5, 2025
09fafe3
Merge branch 'develop' into feature/RDKEMW-6331
srikanth-vv Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ccec/include/ccec/MessageProcessor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:

Check failure on line 3 in ccec/include/ccec/MessageProcessor.hpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'ccec/include/ccec/MessageProcessor.hpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/903ab78, 108 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/903ab7800e37e8f4895b48adf077127670f25710.tar.gz, file: ccec/include/ccec/MessageProcessor.hpp)

Check failure on line 3 in ccec/include/ccec/MessageProcessor.hpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'ccec/include/ccec/MessageProcessor.hpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/2101, 108 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/rdk-dev-2101.tar.gz, file: ccec/include/ccec/MessageProcessor.hpp)
*
* Copyright 2016 RDK Management
*
Expand Down Expand Up @@ -64,11 +64,11 @@
virtual void process (const InActiveSource &msg, const Header &header) {header.print();msg.print();}
virtual void process (const ImageViewOn &msg, const Header &header) {header.print();msg.print();}
virtual void process (const TextViewOn &msg, const Header &header) {header.print();msg.print();}
virtual void process (const RequestActiveSource &msg, const Header &header) {header.print();msg.print();}
virtual void process (const RequestActiveSourceMessage &msg, const Header &header) {header.print();msg.print();}
virtual void process (const Standby &msg, const Header &header) {header.print();msg.print();}
virtual void process (const GetCECVersion &msg, const Header &header) {header.print();msg.print();}
virtual void process (const CECVersion &msg, const Header &header) {header.print();msg.print();}
virtual void process (const SetMenuLanguage &msg, const Header &header) {header.print();msg.print();}
virtual void process (const SetMenuLanguageMessage &msg, const Header &header) {header.print();msg.print();}
virtual void process (const GiveOSDName &msg, const Header &header) {header.print();msg.print();}
virtual void process (const GivePhysicalAddress &msg, const Header &header) {header.print();msg.print();}
virtual void process (const GiveDeviceVendorID &msg, const Header &header) {header.print();msg.print();}
Expand All @@ -89,7 +89,7 @@
virtual void process (const Polling &msg, const Header &header) {header.print();msg.print();}
virtual void process (const InitiateArc &msg, const Header &header) {header.print();msg.print();}
virtual void process (const TerminateArc &msg, const Header &header) {header.print();msg.print();}
virtual void process (const RequestShortAudioDescriptor &msg,const Header &header) {header.print();msg.print();}
virtual void process (const RequestShortAudioDescriptorMessage &msg,const Header &header) {header.print();msg.print();}
virtual void process (const ReportShortAudioDescriptor &msg, const Header &header) {header.print();msg.print();}
virtual void process (const SystemAudioModeRequest &msg , const Header &header) {header.print();msg.print();}
virtual void process (const SetSystemAudioMode &msg , const Header &header) {header.print();msg.print();}
Expand Down
14 changes: 7 additions & 7 deletions ccec/include/ccec/Messages.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:

Check failure on line 3 in ccec/include/ccec/Messages.hpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'ccec/include/ccec/Messages.hpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/2.1-20161130, 658 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/2.1-20161130.tar.gz, file: ccec/include/ccec/Messages.hpp)

Check failure on line 3 in ccec/include/ccec/Messages.hpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'ccec/include/ccec/Messages.hpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/903ab78, 658 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/903ab7800e37e8f4895b48adf077127670f25710.tar.gz, file: ccec/include/ccec/Messages.hpp)

Check failure on line 3 in ccec/include/ccec/Messages.hpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'ccec/include/ccec/Messages.hpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/2101, 693 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/rdk-dev-2101.tar.gz, file: ccec/include/ccec/Messages.hpp)
*
* Copyright 2016 RDK Management
*
Expand Down Expand Up @@ -146,7 +146,7 @@
PhysicalAddress physicalAddress;
};

class RequestActiveSource : public DataBlock
class RequestActiveSourceMessage : public DataBlock
{
public:
Op_t opCode(void) const {return REQUEST_ACTIVE_SOURCE;}
Expand Down Expand Up @@ -187,15 +187,15 @@
Version version;
};

class SetMenuLanguage : public DataBlock
class SetMenuLanguageMessage : public DataBlock
{

public:
Op_t opCode(void) const {return SET_MENU_LANGUAGE;}

SetMenuLanguage(const Language &language) : language(language) {};
SetMenuLanguageMessage(const Language &language) : language(language) {};

SetMenuLanguage(const CECFrame &frame, int startPos = 0)
SetMenuLanguageMessage(const CECFrame &frame, int startPos = 0)
: language(frame, startPos)
{
}
Expand Down Expand Up @@ -463,13 +463,13 @@
PhysicalAddress toSink;
};

class RequestShortAudioDescriptor : public DataBlock
class RequestShortAudioDescriptorMessage : public DataBlock
{

public:
Op_t opCode(void) const {return REQUEST_SHORT_AUDIO_DESCRIPTOR;}

RequestShortAudioDescriptor(const std::vector<uint8_t> formatid, const std::vector<uint8_t> audioFormatCode, uint8_t number_of_descriptor = 1)
RequestShortAudioDescriptorMessage(const std::vector<uint8_t> formatid, const std::vector<uint8_t> audioFormatCode, uint8_t number_of_descriptor = 1)
{
uint8_t audioFormatIdCode;
numberofdescriptor = number_of_descriptor > 4 ? 4 : number_of_descriptor;
Expand All @@ -480,7 +480,7 @@
}
}
/* called by the messaged_decoder */
RequestShortAudioDescriptor(const CECFrame &frame, int startPos = 0)
RequestShortAudioDescriptorMessage(const CECFrame &frame, int startPos = 0)
{
uint8_t len = frame.length();
numberofdescriptor = len > 4 ? 4:len;
Expand Down
6 changes: 3 additions & 3 deletions ccec/src/MessageDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:

Check failure on line 3 in ccec/src/MessageDecoder.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'ccec/src/MessageDecoder.cpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/2010, 146 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/rdk-dev-2010.tar.gz, file: ccec/src/MessageDecoder.cpp)

Check failure on line 3 in ccec/src/MessageDecoder.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'ccec/src/MessageDecoder.cpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/2101, 152 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/rdk-dev-2101.tar.gz, file: ccec/src/MessageDecoder.cpp)
*
* Copyright 2016 RDK Management
*
Expand Down Expand Up @@ -69,7 +69,7 @@
processor.process(TextViewOn(), header);
break;
case REQUEST_ACTIVE_SOURCE:
processor.process(RequestActiveSource(), header);
processor.process(RequestActiveSourceMessage(), header);
break;
case STANDBY:
CCEC_LOG( LOG_DEBUG, "Decoding STANDBY\r\n");
Expand All @@ -82,7 +82,7 @@
processor.process(CECVersion(in), header);
break;
case SET_MENU_LANGUAGE:
processor.process(SetMenuLanguage(in), header);
processor.process(SetMenuLanguageMessage(in), header);
break;
case GIVE_OSD_NAME:
processor.process(GiveOSDName(), header);
Expand Down Expand Up @@ -154,7 +154,7 @@
processor.process(TerminateArc(), header);
break;
case REQUEST_SHORT_AUDIO_DESCRIPTOR:
processor.process(RequestShortAudioDescriptor(in), header);
processor.process(RequestShortAudioDescriptorMessage(in), header);
break;

case REPORT_SHORT_AUDIO_DESCRIPTOR:
Expand Down
8 changes: 4 additions & 4 deletions tests/CECMonitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:

Check failure on line 3 in tests/CECMonitor.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'tests/CECMonitor.cpp' (Match: rdk/components/generic/hdmicec/rdk/components/generic/hdmicec/1812, 251 lines, url: https://code.rdkcentral.com/r/plugins/gitiles/rdk/components/generic/hdmicec/+archive/RDK-DEV-1812.tar.gz, file: tests/CECMonitor.cpp)
*
* Copyright 2016 RDK Management
*
Expand Down Expand Up @@ -87,10 +87,10 @@
printHeader(header);
printf("Command: TextViewOn\n");
}
void process (const RequestActiveSource &msg, const Header &header)
void process (const RequestActiveSourceMessage &msg, const Header &header)
{
printHeader(header);
printf("Command: RequestActiveSource\n");
printf("Command: RequestActiveSourceMessage\n");
}
void process (const Standby &msg, const Header &header)
{
Expand All @@ -108,10 +108,10 @@
printf("Command: CECVersion\n");
printf("Version : %s \n",msg.version.toString().c_str());
}
void process (const SetMenuLanguage &msg, const Header &header)
void process (const SetMenuLanguageMessage &msg, const Header &header)
{
printHeader(header);
printf("Command: SetMenuLanguage\n");
printf("Command: SetMenuLanguageMessage\n");
printf("Language : %s \n",msg.language.toString().c_str());
}
void process (const GiveOSDName &msg, const Header &header)
Expand Down
Loading