RDKB-65709: Integrate baseline changes for XER2 in GwProvApp#39
Open
vysakhav wants to merge 2 commits into
Open
RDKB-65709: Integrate baseline changes for XER2 in GwProvApp#39vysakhav wants to merge 2 commits into
vysakhav wants to merge 2 commits into
Conversation
Reason for change: Incorporate baseline changes for XER2 in GwProvApp component. Test Procedure: 1. Build should be suucessful 2. GwProvApp should be running Priority:P2 Signed-off-by: Vysakh A V <vysakh.venugopal@sky.uk>
There was a problem hiding this comment.
Pull request overview
Integrates XER2 baseline behavior into the GwProvApp global-product state machine by removing Sky-specific compile-time guards and enabling vendor-specific sysevent configuration via runtime PartnerID detection.
Changes:
- Removes
_SCER11BEL_PRODUCT_REQ_/_SCXF11BFL_PRODUCT_REQ_preprocessor guards around vendor-class generation helpers. - Makes the Sky UK PartnerID path always available (under
_RDKB_GLOBAL_PRODUCT_REQ_) to set vendor-specific sysevent config and triggergw_lan_refresh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1440
to
1442
| { | ||
| set_vendor_spec_conf(); | ||
| v_secure_system("gw_lan_refresh &"); |
| return FALSE; | ||
| } | ||
|
|
||
| #if defined(_SCER11BEL_PRODUCT_REQ_) || defined(_SCXF11BFL_PRODUCT_REQ_) |
There was a problem hiding this comment.
changes made which aren't specific to XER2 platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Incorporate baseline changes for XER2 in GwProvApp component.
Test Procedure:
Priority:P2
Risks: Low
Signed-off-by: Vysakh A V vysakh.venugopal@sky.uk
BUILD Verification with the custom branch is ok:
Reference: https://gerrit.teamccp.com/#/c/961708/