RDKEMW-19316 : Add coding guidelines for firebolt-cpp-transport#102
Open
swethasukumarr wants to merge 9 commits into
Open
RDKEMW-19316 : Add coding guidelines for firebolt-cpp-transport#102swethasukumarr wants to merge 9 commits into
swethasukumarr wants to merge 9 commits into
Conversation
swethasukumarr
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a comprehensive, evidence-backed coding guidelines document for the firebolt-cpp-transport C++ transport layer and links to it from the existing Copilot instructions to help contributors/AI agents follow established repo patterns.
Changes:
- Introduces a detailed coding guidelines document covering architecture, naming, memory/threading, error handling, logging, testing, and JSON patterns.
- Adds a “Coding Guidelines” section to
.github/copilot-instructions.mdintended to point readers to the new guidelines document.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/instructions/coding-guidelines.instructions.md |
Adds the new guidelines document (large, evidence-based rules and rationale). |
.github/copilot-instructions.md |
Adds a pointer/link to the coding guidelines. |
swethasukumarr
force-pushed
the
feature/RDKEMW-19316
branch
from
July 15, 2026 15:08
3b76da7 to
a75eb9d
Compare
swethasukumarr
force-pushed
the
feature/RDKEMW-19316
branch
from
July 15, 2026 15:11
a75eb9d to
15916a2
Compare
swethasukumarr
force-pushed
the
feature/RDKEMW-19316
branch
from
July 15, 2026 18:37
ca4915e to
a38dfc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.