Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
128 commits
Select commit Hold shift + click to select a range
469da7f
feat: Openspec init
satlead Mar 10, 2026
86468d6
feat: Add specs
satlead Mar 10, 2026
92681e0
feat: Refactor language specific information
satlead Mar 10, 2026
f40da18
feat: Header support proposal
satlead Mar 13, 2026
3b4e6cd
feat: Add headers field to Config Struct
satlead Mar 13, 2026
5310b34
feat: Add Header support for connect method
satlead Mar 13, 2026
b333fd6
feat: Implement getResponseHeader and thread safety
satlead Mar 13, 2026
aac9015
feat: Add Unittest and integration tests
satlead Mar 13, 2026
3c8e9c1
Merge branch 'main' of github.com:rdkcentral/firebolt-cpp-transport i…
satlead Mar 13, 2026
9da6d90
style: clang formatter
tomasz-blasz Mar 13, 2026
837a962
fix: Compilation errors
tomasz-blasz Mar 13, 2026
6fe772c
refactor: Change support for headers
tomasz-blasz Mar 13, 2026
1c53afc
Revert "refactor: Change support for headers"
satlead Mar 16, 2026
754c4fe
feat: Add Documentation
satlead Mar 16, 2026
009f2a5
feat: Fix to use opsx commands
satlead Mar 16, 2026
c2054c9
feat: Archive the changes for header support
satlead Mar 16, 2026
13bd09a
feat: slidev updates
satlead Mar 27, 2026
858e903
fix: Fix Header
satlead Mar 27, 2026
bf2de87
Fix: Slides
satlead Mar 27, 2026
75a249e
fix: Changes
satlead Mar 27, 2026
c20138c
feat: Final touches and PDF generation
satlead Mar 30, 2026
7e1a16a
feat: Slide update
satlead Apr 15, 2026
529cd21
feat: Before Standard
satlead Apr 17, 2026
1033a23
Feat: Open Spec coverage
satlead Apr 17, 2026
c03fe8d
fix: Add support for Covered code section
satlead Apr 24, 2026
bf75a3c
fix: Covered code section branch
satlead Apr 27, 2026
7ade962
Fix: regex
satlead Apr 27, 2026
6648276
Fix: Proposal format rules
satlead Apr 27, 2026
3ddb44c
Merge branch 'develop' of github.com:rdkcentral/firebolt-cpp-transpor…
satlead Jun 3, 2026
ffba529
Merge branch 'develop' of github-public:rdkcentral/firebolt-cpp-trans…
Jun 16, 2026
fb11e34
Potential fix for pull request finding
brendanobra Jun 16, 2026
2f1aef6
Potential fix for pull request finding
brendanobra Jun 16, 2026
cea889a
Potential fix for pull request finding
brendanobra Jun 16, 2026
21e402c
fix: Address PR review feedback
Jun 16, 2026
3a02b5e
Potential fix for pull request finding
brendanobra Jun 16, 2026
7ad4741
Potential fix for pull request finding
brendanobra Jun 16, 2026
159a1c7
Potential fix for pull request finding
brendanobra Jun 16, 2026
7e571bb
Potential fix for pull request finding
brendanobra Jun 16, 2026
6be87d8
Potential fix for pull request finding
brendanobra Jun 16, 2026
4a0350e
Potential fix for pull request finding
brendanobra Jun 16, 2026
1ba08f0
Potential fix for pull request finding
brendanobra Jun 16, 2026
878ef95
Potential fix for pull request finding
brendanobra Jun 16, 2026
7820148
Potential fix for pull request finding
brendanobra Jun 16, 2026
cf99982
Potential fix for pull request finding
brendanobra Jun 16, 2026
f0ed7f4
Potential fix for pull request finding
brendanobra Jun 16, 2026
f8f44ed
Potential fix for pull request finding
brendanobra Jun 16, 2026
61a7452
Potential fix for pull request finding
brendanobra Jun 16, 2026
829317d
fix: Address mhughesacn review - remove binary PDF, add MIT license t…
Jun 17, 2026
c959eb3
Merge pull request #91 from rdkcentral/openspec-guidelines
brendanobra Jun 23, 2026
1326abd
RDKEMW-17673 : Add info coverage gate to CI
swethasukumarr Jun 17, 2026
eea66d8
RDKEMW-17673 : Refactor coverage gate script and test file
swethasukumarr Jun 23, 2026
6b465ca
RDKEMW-17673 : Refactor workflow
swethasukumarr Jun 26, 2026
7f39565
RDKEMW-17673 : Fix copilot comments
swethasukumarr Jun 26, 2026
451c386
Merge pull request #97 from rdkcentral/feature/RDKEMW-17673
swethasukumarr Jun 26, 2026
28d092a
feat: env var configurable logging
Jul 1, 2026
3a742f8
feat: version reporting to logs
Jul 1, 2026
9d43a47
Update README.md
brendanobra Jul 7, 2026
ec0e7b1
fix: (maybe) disconnect cancel/blocking
Jul 7, 2026
2f82cba
Merge branch 'nojira/runtime-configurable-looging' of github-public:r…
Jul 7, 2026
aa93147
fix: Address PR #98 review feedback
Jul 7, 2026
bfe1236
noop: trigger ci
Jul 7, 2026
49e214b
noop: trigger ci
Jul 7, 2026
e168083
fix: Address second round of PR #98 review feedback
Jul 7, 2026
ce0c558
Potential fix for pull request finding
brendanobra Jul 7, 2026
3eab23d
fix: Address third round of PR #98 review feedback
Jul 7, 2026
909fe2d
Merge remote changes: resolve README.md conflict and keep checkPromis…
Jul 7, 2026
630cf6c
Address all remaining PR #98 review feedback
Jul 7, 2026
2c17bf5
Fix remaining PR #98 review feedback
Jul 7, 2026
49fc0c8
Fix incomplete changes from previous commits
Jul 7, 2026
1f3cd8f
Merge branch 'nojira/runtime-configurable-looging' of github-public:r…
Jul 7, 2026
b07b75c
Fix CodeQL security vulnerabilities and CMakeLists.txt corruption
Jul 7, 2026
805c7cd
Address new PR #98 review feedback
Jul 7, 2026
0935a82
Fix Coverity issues in loggerTest.cpp
Jul 7, 2026
7a158ef
Restructure mkstemp/close pattern to satisfy Coverity NEGATIVE_RETURNS
Jul 7, 2026
7193398
Replace mkstemp with mkostemp to eliminate Coverity SECURE_TEMP
Jul 7, 2026
7c5f4bc
Fix CTAD lock_guard in PR-added code (gateway.cpp)
Jul 7, 2026
8136d2f
Fix CodeQL 'uncontrolled data in path expression' with realpath() san…
Jul 7, 2026
a2500b9
Fix corrupted Apache license header in test/CMakeLists.txt
Jul 7, 2026
09e1129
Potential fix for pull request finding
brendanobra Jul 7, 2026
79d45ab
Fix README doc/code mismatch and remove stale include
Jul 7, 2026
71cc832
Merge remote README fix; remove stale <sys/stat.h> from loggerTest
Jul 7, 2026
6d2fe73
Use openat() via trusted dirfd to fix CodeQL path-injection alert
Jul 7, 2026
99fddbe
Fix write() loop that breaks log-line atomicity
Jul 7, 2026
40eb66c
Add lgtm suppression for CodeQL cpp/path-injection false positive
Jul 8, 2026
85378fe
Address 6 active unresolved review threads
Jul 8, 2026
97a77fc
Potential fix for pull request finding
brendanobra Jul 8, 2026
e90ad8c
Potential fix for pull request finding
brendanobra Jul 8, 2026
ad6d190
Potential fix for pull request finding
brendanobra Jul 8, 2026
3181afd
Fix clang-format violation in gateway.cpp
Jul 8, 2026
f6a5428
Fix Coverity COPY_INSTEAD_OF_MOVE in resolveLogFilePathFromEnvironment
Jul 8, 2026
6a0c7a2
Potential fix for pull request finding
brendanobra Jul 8, 2026
8d92562
Potential fix for pull request finding
brendanobra Jul 8, 2026
8e0516c
Suppress -Wformat-security in MalformedFormatDoesNotCrash test
Jul 8, 2026
5b1c4d5
Address 3 new review findings
Jul 8, 2026
13a8c3c
Fix 3 new review findings (logger.cpp + logger.h)
Jul 8, 2026
7500dcd
Fix 3 more review findings
Jul 8, 2026
adee69f
Fix High: snprintf accumulator OOB in Logger::log()
Jul 8, 2026
a546c17
Potential fix for pull request finding
brendanobra Jul 8, 2026
cd90bdf
Fix 2 more review findings (gateway.cpp + logger.cpp)
Jul 8, 2026
1b2b078
Potential fix for pull request finding
brendanobra Jul 8, 2026
2bde565
Potential fix for pull request finding
brendanobra Jul 8, 2026
6455a0f
Potential fix for pull request finding
brendanobra Jul 8, 2026
c158b2c
Potential fix for pull request finding
brendanobra Jul 8, 2026
899caa6
Fix Copilot autofix regressions from accepted suggestions
Jul 8, 2026
5265db4
Fix fmt.sh for submodule context
Jul 8, 2026
ced7ea1
Address 4 new review findings (gateway.cpp + logger.cpp)
Jul 8, 2026
6df61f5
Fix response(): defensive error field parsing to prevent crash
Jul 8, 2026
0654a60
Potential fix for pull request finding
brendanobra Jul 8, 2026
0877cf9
Fix UB in resolveLogFilePathFromEnvironment() truncation check
Jul 8, 2026
19c0b9b
Fix gcovr parse error: add --gcov-ignore-parse-errors=negative_hits.warn
Jul 8, 2026
3b0f4c1
Merge pull request #98 from rdkcentral/nojira/runtime-configurable-lo…
brendanobra Jul 8, 2026
72f22a7
merge(main): integrate develop with conflict resolution for PR #100
Jul 14, 2026
49948dd
test(gateway): stabilize no-server failure paths for async connect
Jul 14, 2026
df222ee
fix(review): address PR #101 transport and gateway feedback
Jul 14, 2026
2f86980
fix(license): remove unresolved MIT placeholder block
Jul 14, 2026
099f94e
fix(review): address latest gateway, test, and docs feedback
Jul 14, 2026
d79c64b
fix(review): prevent in-flight reconnect races and stale headers
Jul 14, 2026
3841e9d
fix(transport): address review feedback on headers and tests
Jul 14, 2026
93e8647
fix(transport): address additional PR review feedback
Jul 14, 2026
6d3b026
fix(test): remove remaining TOCTOU port races
Jul 14, 2026
4168f6f
fix(transport): address callback ordering and lock contention
Jul 14, 2026
cde73b2
fix(test/docs): address new PR review comments
Jul 14, 2026
15adef8
fix(headers): address review feedback on includes and moves
Jul 14, 2026
0b20234
fix(logger): avoid inserting syslog priority lookups
Jul 14, 2026
802d182
fix(transport): harden onOpen and tighten header test
Jul 14, 2026
6e072c3
fix(transport): use single state load in connect guard
Jul 14, 2026
2138256
fix(logger/coverage): avoid inserting lookups and skip conversion ops
Jul 14, 2026
12b456f
fix(logger/transport): tighten casts and header injection safety
Jul 14, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 149 additions & 0 deletions .github/prompts/opsx-apply.prompt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
---
description: Implement tasks from an OpenSpec change (Experimental)
---

Implement tasks from an OpenSpec change.

**Input**: Optionally specify a change name (e.g., `/opsx:apply add-auth`). If omitted, check if it can be inferred from conversation context. If vague or ambiguous you MUST prompt for available changes.

**Steps**

1. **Select the change**

If a name is provided, use it. Otherwise:
- Infer from conversation context if the user mentioned a change
- Auto-select if only one active change exists
- If ambiguous, run `openspec list --json` to get available changes and use the **AskUserQuestion tool** to let the user select

Always announce: "Using change: <name>" and how to override (e.g., `/opsx:apply <other>`).

2. **Check status to understand the schema**
```bash
openspec status --change "<name>" --json
```
Parse the JSON to understand:
- `schemaName`: The workflow being used (e.g., "spec-driven")
- Which artifact contains the tasks (typically "tasks" for spec-driven, check status for others)

3. **Get apply instructions**

```bash
openspec instructions apply --change "<name>" --json
```

This returns:
- Context file paths (varies by schema)
- Progress (total, complete, remaining)
- Task list with status
- Dynamic instruction based on current state

**Handle states:**
- If `state: "blocked"` (missing artifacts): show message, suggest using `/opsx:continue`
- If `state: "all_done"`: congratulate, suggest archive
- Otherwise: proceed to implementation

4. **Read context files**

Read the files listed in `contextFiles` from the apply instructions output.
The files depend on the schema being used:
- **spec-driven**: proposal, specs, design, tasks
- Other schemas: follow the contextFiles from CLI output

5. **Show current progress**

Display:
- Schema being used
- Progress: "N/M tasks complete"
- Remaining tasks overview
- Dynamic instruction from CLI

6. **Implement tasks (loop until done or blocked)**

For each pending task:
- Show which task is being worked on
- Make the code changes required
- Keep changes minimal and focused
- Mark task complete in the tasks file: `- [ ]` → `- [x]`
- Continue to next task

**Pause if:**
- Task is unclear → ask for clarification
- Implementation reveals a design issue → suggest updating artifacts
- Error or blocker encountered → report and wait for guidance
- User interrupts

7. **On completion or pause, show status**

Display:
- Tasks completed this session
- Overall progress: "N/M tasks complete"
- If all done: suggest archive
- If paused: explain why and wait for guidance

**Output During Implementation**

```
## Implementing: <change-name> (schema: <schema-name>)

Working on task 3/7: <task description>
[...implementation happening...]
✓ Task complete

Working on task 4/7: <task description>
[...implementation happening...]
✓ Task complete
```

**Output On Completion**

```
## Implementation Complete

**Change:** <change-name>
**Schema:** <schema-name>
**Progress:** 7/7 tasks complete ✓

### Completed This Session
- [x] Task 1
- [x] Task 2
...

All tasks complete! You can archive this change with `/opsx:archive`.
```

**Output On Pause (Issue Encountered)**

```
## Implementation Paused

**Change:** <change-name>
**Schema:** <schema-name>
**Progress:** 4/7 tasks complete

### Issue Encountered
<description of the issue>

**Options:**
1. <option 1>
2. <option 2>
3. Other approach

What would you like to do?
```

**Guardrails**
- Keep going through tasks until done or blocked
- Always read context files before starting (from the apply instructions output)
- If task is ambiguous, pause and ask before implementing
- If implementation reveals issues, pause and suggest artifact updates
- Keep code changes minimal and scoped to each task
- Update task checkbox immediately after completing each task
- Pause on errors, blockers, or unclear requirements - don't guess
- Use contextFiles from CLI output, don't assume specific file names

**Fluid Workflow Integration**

This skill supports the "actions on a change" model:

- **Can be invoked anytime**: Before all artifacts are done (if tasks exist), after partial implementation, interleaved with other actions
- **Allows artifact updates**: If implementation reveals design issues, suggest updating artifacts - not phase-locked, work fluidly
154 changes: 154 additions & 0 deletions .github/prompts/opsx-archive.prompt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,154 @@
---
description: Archive a completed change in the experimental workflow
---

Archive a completed change in the experimental workflow.

**Input**: Optionally specify a change name after `/opsx:archive` (e.g., `/opsx:archive add-auth`). If omitted, check if it can be inferred from conversation context. If vague or ambiguous you MUST prompt for available changes.

**Steps**

1. **If no change name provided, prompt for selection**

Run `openspec list --json` to get available changes. Use the **AskUserQuestion tool** to let the user select.

Show only active changes (not already archived).
Include the schema used for each change if available.

**IMPORTANT**: Do NOT guess or auto-select a change. Always let the user choose.

2. **Check artifact completion status**

Run `openspec status --change "<name>" --json` to check artifact completion.

Parse the JSON to understand:
- `schemaName`: The workflow being used
- `artifacts`: List of artifacts with their status (`done` or other)

**If any artifacts are not `done`:**
- Display warning listing incomplete artifacts
- Prompt user for confirmation to continue
- Proceed if user confirms

3. **Check task completion status**

Read the tasks file (typically `tasks.md`) to check for incomplete tasks.

Count tasks marked with `- [ ]` (incomplete) vs `- [x]` (complete).

**If incomplete tasks found:**
- Display warning showing count of incomplete tasks
- Prompt user for confirmation to continue
- Proceed if user confirms

**If no tasks file exists:** Proceed without task-related warning.

4. **Assess delta spec sync state**

Check for delta specs at `openspec/changes/<name>/specs/`. If none exist, proceed without sync prompt.

**If delta specs exist:**
- Compare each delta spec with its corresponding main spec at `openspec/specs/<capability>/spec.md`
- Determine what changes would be applied (adds, modifications, removals, renames)
- Show a combined summary before prompting

**Prompt options:**
- If changes needed: "Sync now (recommended)", "Archive without syncing"
- If already synced: "Archive now", "Sync anyway", "Cancel"

If user chooses sync, use Task tool (subagent_type: "general-purpose", prompt: "Use Skill tool to invoke openspec-sync-specs for change '<name>'. Delta spec analysis: <include the analyzed delta spec summary>"). Proceed to archive regardless of choice.

5. **Perform the archive**

Create the archive directory if it doesn't exist:
```bash
mkdir -p openspec/changes/archive
```

Generate target name using current date: `YYYY-MM-DD-<change-name>`

**Check if target already exists:**
- If yes: Fail with error, suggest renaming existing archive or using different date
- If no: Move the change directory to archive

```bash
mv openspec/changes/<name> openspec/changes/archive/YYYY-MM-DD-<name>
```

6. **Display summary**

Show archive completion summary including:
- Change name
- Schema that was used
- Archive location
- Spec sync status (synced / sync skipped / no delta specs)
- Note about any warnings (incomplete artifacts/tasks)

**Output On Success**

```
## Archive Complete

**Change:** <change-name>
**Schema:** <schema-name>
**Archived to:** openspec/changes/archive/YYYY-MM-DD-<name>/
**Specs:** ✓ Synced to main specs

All artifacts complete. All tasks complete.
```

**Output On Success (No Delta Specs)**

```
## Archive Complete

**Change:** <change-name>
**Schema:** <schema-name>
**Archived to:** openspec/changes/archive/YYYY-MM-DD-<name>/
**Specs:** No delta specs

All artifacts complete. All tasks complete.
```

**Output On Success With Warnings**

```
## Archive Complete (with warnings)

**Change:** <change-name>
**Schema:** <schema-name>
**Archived to:** openspec/changes/archive/YYYY-MM-DD-<name>/
**Specs:** Sync skipped (user chose to skip)

**Warnings:**
- Archived with 2 incomplete artifacts
- Archived with 3 incomplete tasks
- Delta spec sync was skipped (user chose to skip)

Review the archive if this was not intentional.
```

**Output On Error (Archive Exists)**

```
## Archive Failed

**Change:** <change-name>
**Target:** openspec/changes/archive/YYYY-MM-DD-<name>/

Target archive directory already exists.

**Options:**
1. Rename the existing archive
2. Delete the existing archive if it's a duplicate
3. Wait until a different date to archive
```

**Guardrails**
- Always prompt for change selection if not provided
- Use artifact graph (openspec status --json) for completion checking
- Don't block archive on warnings - just inform and confirm
- Preserve .openspec.yaml when moving to archive (it moves with the directory)
- Show clear summary of what happened
- If sync is requested, use the Skill tool to invoke `openspec-sync-specs` (agent-driven)
- If delta specs exist, always run the sync assessment and show the combined summary before prompting
Loading
Loading