Skip to content

RDKEMW-19315 : Add coding guidelines for firebolt-cpp-client#91

Open
swethasukumarr wants to merge 6 commits into
developfrom
feature/RDKEMW-19315
Open

RDKEMW-19315 : Add coding guidelines for firebolt-cpp-client#91
swethasukumarr wants to merge 6 commits into
developfrom
feature/RDKEMW-19315

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 13, 2026 17:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new repository-scoped coding-guidelines instruction document intended to standardize how contributors (and AI agents) modify firebolt-cpp-client, with emphasis on module boundaries, naming, testing patterns, and generator-owned surfaces.

Changes:

  • Introduces a comprehensive “Coding Guidelines” instruction file covering architecture layering, naming, error handling, and JSON adapter conventions.
  • Documents expected test patterns (unit/component) and OpenRPC fixture alignment rules.
  • Captures build/CMake conventions and a catalog of repo-specific anti-patterns.

Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI review requested due to automatic review settings July 13, 2026 17:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI review requested due to automatic review settings July 14, 2026 17:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI review requested due to automatic review settings July 14, 2026 17:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/instructions/coding-guidelines.instructions.md
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI review requested due to automatic review settings July 14, 2026 17:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI review requested due to automatic review settings July 14, 2026 17:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI review requested due to automatic review settings July 14, 2026 17:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/instructions/coding-guidelines.instructions.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants